Giter Club home page Giter Club logo

elvis.mk's People

Contributors

andrei-mihaila avatar elbrujohalcon avatar euen avatar jfacorro avatar rlipscombe avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

elvis.mk's Issues

ref c3bb3f5 does not exist

README suggest to configure erlang.mk like

dep_elvis_mk = git https://github.com/inaka/elvis.mk.git c3bb3f5

but

error: pathspec 'c3bb3f5' did not match any file(s) known to git.

Plugin uses GNU-specific options with 'cp', 'rm' and 'rmdir'

This means that it fails on macOS unless you have GNU cp/rm/rmdir ahead of the BSD ones in $PATH. For example:

cp: illegal option -- -
usage: cp [-R [-H | -L | -P]] [-fi | -n] [-aclpsvXx] source_file target_file
       cp [-R [-H | -L | -P]] [-fi | -n] [-aclpsvXx] source_file ... target_directory
make: *** [foo/deps/elvis_mk/plugins.mk:39: foo/elvis] Error 64

false warnings about dynamic module calls

Please see https://gist.github.com/sstrigler/34f72edb8d1134e9de5c

Using erlang.mk and elvis.mk as of

dep_elvis_mk = git https://github.com/inaka/elvis.mk.git c3bb3f5

Downloads elvis from:

--2016-01-26 15:54:33--  https://github.com/inaka/elvis/releases/download/0.2.5/elvis
Resolving github.com (github.com)... 192.30.252.130
Connecting to github.com (github.com)|192.30.252.130|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://github-cloud.s3.amazonaws.com/releases/21137327/8675a422-509c-11e5-814b-e82bc6d7ecec?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAISTNZFOVBIJMK3TQ%2F20160126%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20160126T155616Z&X-Amz-Expires=300&X-Amz-Signature=062e5b3877d32e5783aa9ace6b2a2e0732085f6954c15703f46c82d1dcb80904&X-Amz-SignedHeaders=host&actor_id=0&response-content-disposition=attachment%3B%20filename%3Delvis&response-content-type=application%2Foctet-stream [following]
--2016-01-26 15:54:33--  https://github-cloud.s3.amazonaws.com/releases/21137327/8675a422-509c-11e5-814b-e82bc6d7ecec?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAISTNZFOVBIJMK3TQ%2F20160126%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20160126T155616Z&X-Amz-Expires=300&X-Amz-Signature=062e5b3877d32e5783aa9ace6b2a2e0732085f6954c15703f46c82d1dcb80904&X-Amz-SignedHeaders=host&actor_id=0&response-content-disposition=attachment%3B%20filename%3Delvis&response-content-type=application%2Foctet-stream
Resolving github-cloud.s3.amazonaws.com (github-cloud.s3.amazonaws.com)... 54.231.98.104
Connecting to github-cloud.s3.amazonaws.com (github-cloud.s3.amazonaws.com)|54.231.98.104|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 419149 (409K) [application/octet-stream]
Saving to: ‘/home/stefan/src/llfm/elvis’

Erlang version used is 18.1

Fulfil the Open-Source Checklist

General Items

Exhibition

  • It's shared on social networks
  • It's shared on reddit
  • It's shared on hacker news with a title like Show HN: description

For Libraries

  • Examples of use are documented in the README or linked from there

For Erlang/Elixir Projects

Make the Elvis version configurable

The current version installs an old (6 years old) version of Elvis. It would be nice if it installed a newer version (at the user's choice).

Also, that old version of Elvis is a compiled one and doesn't work with Erlang/OTP 25.

$ make elvis
 DEP    elvis_mk (1.0.0)
 GEN    /redacted-path/elvis
=ERROR REPORT==== 5-Aug-2022::19:27:30.125393 ===
beam/beam_load.c(148): Error loading module elvis:
  please re-compile this module with an Erlang/OTP 25 compiler


escript: exception error: undefined function elvis:main/1
  in function  escript:run/2 (escript.erl, line 750)
  in call from escript:start/1 (escript.erl, line 277)
  in call from init:start_em/1 
  in call from init:do_boot/3 
make: *** [/redacted-path/deps/elvis_mk/plugins.mk:36: elvis] Error 127

There is a fix in #15 - but will probably need some improvements as it relies on rebar3 being available.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.