Giter Club home page Giter Club logo

Comments (6)

msub2 avatar msub2 commented on June 7, 2024

I've figured out the issue, the three.js update did in fact break things since they switched to using bare imports for three in the example files. Adding an importmap in the index.html seems to fix this, but there's now other issues since we're jumping 20+ versions. I'll try and iron this out and PR.

Update: I currently have it working on Chrome, but since it requires import maps to function I'm unable to get it working on Firefox. Even using es-module-shims to try and polyfill it isn't working, seemingly due to an issue with how the polyfill handles cyclic dependencies or somesuch (I believe this issue is essentially what's happening here guybedford/es-module-shims#270). I'd say the easiest fix for now would just be to revert back to r113, or at least the latest version before they switched to using bare imports, which I believe is r127.

from webxr-input-profiles.

cabanier avatar cabanier commented on June 7, 2024

@toji Maybe we can downgrade three.js to 127?
I verified that it fixes the problem

from webxr-input-profiles.

toji avatar toji commented on June 7, 2024

Reverting to 127 sounds good to me.

from webxr-input-profiles.

toji avatar toji commented on June 7, 2024

Pushed 614bf32. Works locally, I'll keep an eye on it to see if it deploys properly.

from webxr-input-profiles.

msub2 avatar msub2 commented on June 7, 2024

Deployment looks good! I'll send in a PR later to address a couple API changes in three.js.

from webxr-input-profiles.

cabanier avatar cabanier commented on June 7, 2024

This is working now. Closing

from webxr-input-profiles.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.