Script error - Update Check Runs about ok-to-test HOT 3 CLOSED

Worked out what the issue was. The GITHUB_TOKEN needed additional permissions (read/write) in Settings > Actions > General > Workflow Permissions (or could be done more granularly in the Workflow YAML). May be worth updating the docs to include this?

I was also wondering if you felt this workflow was still relevant in light of this feature: https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks
EDIT: answering my own question, I think it is still relevant because it means that you can control access to integrations tests that may cost more money separately to all other actions / workflows / tests that you may have in the repository.

from ok-to-test.

The documentation of this workflow is out of date, as you #21 (comment)! Would you be willing to open a separate PR for that? 🙏

Sure. I'll adjust the docs to mention the GITHUB_TOKEN permissions. I'll also explicitly mention that it is ok to use 'example.com' type urls when creating the GitHub app. When I was creating my app, I wasn't sure that it would be ok to use URLs that didn't resolve, or that I didn't own. I noticed #12 also referenced this, so thought it may be worth bulking the docs out a bit on this if that is OK?

from ok-to-test.

Thanks for the issue report and PR! 😍

I think a couple of things are going on:

• The built-in GITHUB_TOKEN's defaults were recently changed to read-only, so explicit write permissions are helpful in the workflow, as you indicate here (or the defaults could be set at the enterprise, organization, or repo level). GITHUB_TOKEN is technically a special GitHub App installation access token generated by GitHub Actions but is unrelated to the other installation access token we generate here and optionally use here.
• The documentation of this workflow is out of date, as you also indicate! Would you be willing to open a separate PR for that? 🙏

from ok-to-test.