Why invoke a repo dispatch event? Can’t we instead open a check run from the issue_com

Would something like this work: <p dir="au

Question about ok-to-test HOT 1 CLOSED

hamelsmu commented on June 12, 2024

Question

from ok-to-test.

Comments (1)

imjohnbo commented on June 12, 2024 1

Would something like this work:

If owner OR comment = “/ok-to-test”
.> ..tests?

Good question @hamelsmu – yes! I was envisioning more slash commands like deploy being parsed in a separate workflow (now called ok-to-test.yml). It's a tradeoff of complexity, which is now hidden behind the helper action(s) in ok-to-test.yml.

peter-evans/slash-command-dispatch takes care of a few other things that I'd want to see in a test-centric solution, like reacting back on the comment, ensuring the permission level of the commenter, restricting the issue type, and grabbing the pull request number that the test workflow can use.

Maybe we should make this into a stop/go action that takes an issue_comment, decides if it's a valid comment from a permissioned author, and proceeds. 🤔This part to update the PR check could also be a separate action:

ok-to-test/.github/workflows/integration.yml

Lines 40 to 71 in 02903c4

  # Update check run called "integration-fork" 

 - uses: actions/github-script@v1 

 id: update-check-run 

 env: 

 number: ${{ github.event.client_payload.pull_request.number }} 

 job: ${{ github.job }} 

 # Conveniently, job.status maps to https://developer.github.com/v3/checks/runs/#update-a-check-run 

 conclusion: ${{ job.status }}  

 with: 

 github-token: ${{ secrets.GITHUB_TOKEN }} 

 script: | 

  const { data: pull } = await github.pulls.get({ 

  ...context.repo, 

  pull_number: process.env.number 

  }); 

  const ref = pull.head.sha; 

  const { data: checks } = await github.checks.listForRef({ 

  ...context.repo, 

  ref 

  }); 

  const check = checks.check_runs.filter(c => c.name === process.env.job); 

  const { data: result } = await github.checks.update({ 

  ...context.repo, 

  check_run_id: check[0].id, 

  status: 'completed', 

  conclusion: process.env.conclusion 

  }); 

  return result;

from ok-to-test.

Recommend Projects

Question about ok-to-test HOT 1 CLOSED

Comments (1)

Related Issues (12)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	# Update check run called "integration-fork"
	- uses: actions/github-script@v1
	id: update-check-run
	env:
	number: ${{ github.event.client_payload.pull_request.number }}
	job: ${{ github.job }}
	# Conveniently, job.status maps to https://developer.github.com/v3/checks/runs/#update-a-check-run
	conclusion: ${{ job.status }}
	with:
	github-token: ${{ secrets.GITHUB_TOKEN }}
	script: \|
	const { data: pull } = await github.pulls.get({
	...context.repo,
	pull_number: process.env.number
	});
	const ref = pull.head.sha;

	const { data: checks } = await github.checks.listForRef({
	...context.repo,
	ref
	});

	const check = checks.check_runs.filter(c => c.name === process.env.job);

	const { data: result } = await github.checks.update({
	...context.repo,
	check_run_id: check[0].id,
	status: 'completed',
	conclusion: process.env.conclusion
	});

	return result;