markdown shortcut style is incompatible with HTML styling, so it remains left-aligned. will need to deconstruct the markdown shortcuts and replace them with full hrefs.

Ideas

https://allcontributors.org/

Explore and consider some type of simple quality assurance process (e.g., https://www.codefactor.io)

Similarly, there's no reason to include name_search anymore, correct? It doesn't appear to be called anywhere else.

Describe the bug

Possible bug. Occurred in console while debugging uninstall feature. Possibly result of having both generic_mapper and discMapper loaded simultaneously, so sanitizeRoom breaks with GMCP room name detection.

To Reproduce
Uncertain.

Expected behavior
no error!

Environment (please complete the following information):

• discMapper Version: 0.3.2
• Mudlet Version: 4.9.1
• OS: win10

Dave made a cool auto-updater for packages. Not sure of its status since January 2020, but it might be something to consider as replacement for Jor`Mox's script updating that I suspect has twice erased the discMapper script in my local profiles.

Git Updater

Good idea? Bad idea?

Describe the bug
It's not really a bug, as much as absent/unrequired feature in generic_mapper. Room names and exits are unavailable if discMapper is installed after connecting to the game server, because GMCP core support handshake is triggered by the login sequence, and gmcp.room.info data is called by "look" or movement.

To Reproduce
Steps to reproduce the behavior:

1. Create new profile
2. Install discMapper
3. Issue look
4. Issue map basics, observe red x's
5. ...GMCP events is table empty

Expected behavior

Environment (please complete the following information):

• discMapper Version: 0.3.2-beta/develop
• Mudlet Version: 4.9.1
• OS: win10

Describe the bug
While the versions library file is now present in the correct folder, check_version is till calculating the scrip as 17 versions behind.

To Reproduce
Steps to reproduce the behavior:

1. Install mudlet'
2. Create clean profile
3. Uninstall generic_mapper
4. Install discMapper
5. Connect to mud

Expected behavior
result of 0 - discMapper is current version matching local and remote versions.lua

Environment (please complete the following information):

• discMapper Version: c0.3.1
• Mudlet Version: 4.9.1
• OS: win10

**Additional Context
I could have sworn that I resolved this last night, but the fiasco with github today reeked all manner of havoc on the v0.3.1-beta hot fix. Apparently, I will need to verify additional incorrect or missing commits by doing a file diff with an earlier version on the XML and looking at the save pathing and versions.lua all over again. ugh.

Git Help: Managing commit signature verification

Because we were unable to simply extend generic_mapper, the discMapper script will need to be manually updated when changes are made to the single file in the mudlet repo. How often do we do this? With every new Mudlet release?

This is the XML for my old GMCP Enabled script. It's technically more accurate that what is in discMapper currently, because it only runs when the sysProtocolEnabled event fires and the protocol is, in fact, GMCP. I'm just too tired ATM to mess with it.

<Script isActive="no" isFolder="no">
	<name>dsGMCPEnabled</name>
	<packageName></packageName>
	<script>function dsGMCPEnabled(_, protocol)
		if protocol == "GMCP" then
		map.echo("  - GMCP Enabled")
	end
end</script>

<eventHandlerList>
	<string>sysProtocolEnabled</string>
</eventHandlerList>

Describe the bug
No GMCP data available for use by script.

To Reproduce
Intermittent?!? This may be due to my other profile with core support trigger enabling core supports. When I then load the new profile and drop link on the game from the old profile, the game continues to send GMCP when it otherwise would not have.

Steps to reproduce the behavior:

1. Open a new profile
2. Install discMapper 0.1.2-alpha
3. Connect to game
4. Look (to fire onNewRoom trigger)
5. See error...
   
6. Open edbee
7. Click Statistics
8. Observe empty GMCP table...
   

Expected behavior
GMCP core supports should be sent by game and available to discMapper in the GMCP table.

Screenshots
See above.

Desktop (please complete the following information):

• OS: win10

• Do I want to link my professional identity to this project?
• Will doing so introduce undue potential for unethical dual relationships?
• Can I get around this by filing another Fictitious Firm Name (DBA) on my existing LLC?

- [ ] Rename discMapper_logo.png as discMapper.png

• Move the file to root (the image isn't included in the script, so it needs to get out of /src)
• Update README image location and link URLs

script is on @iLPdev's PC

https://github.com/davidbgk/open-source-template

Consider using @demonnic text formatter for debug display

Tried to make the logo text. Caslon Antique is as close -- if a bit sans serif -- as I was able to find to the font used by Terry Pratchett for the series titles.

Should we go through and replace map.prompt.room with gmcp.room.info.name everywhere or define it once and for all at the beginning? It's not a local variable so the user can alter it as intended, but would there ever be a reason to do so? discMapper sets the room name based on what the game sends rather than misidentified text or location as previously.

It's time now to include a binary, so we'll need to make a package out of this module.

• Demonnic
• Vadi
• Edrame
• SlySven
• Leris
• Edru

Describe the bug
A clear and concise description of what the bug is.

To Reproduce

1. Install discMapper
2. Connect
3. Type map debug
4. Type find prompt
5. look and observe functional room and exit detection
6. Type map basics
7. See error

Expected behavior
Checkmarks for room and exits, allowing start mapping to be called.

Desktop (please complete the following information):

• Version 4.8+

Additional context
Clearly room name and exits are being detected accurately, but our hooking into the move map function seems to be circumventing passing the data to map.currentName, map.currentExits and, I suspect, there is some relation between this bug, get_room_info, how setID, setArea, etc are used.

As far as I can see, there's really no need for trimming lines from Discworld's ASCII map. Even if the user has options display set to left on the game, discMapper is pulling room titles directly from GMCP now - there's never going to be anything to sanitize. If it's not called anywhere else, we should just remove the whole thing rather than comment it out, right?

Consider implementing labeling for the mapper (i.e., Fenton's labelRoomName that was never finished). Fenton was trying to make the mapper automatically label General Store, Shop, Custom, and Food environments only.

Describe the bug

To Reproduce
Steps to reproduce the behavior:

1. Clean profile
2. Connect
3. Install discMapper
4. See error in console

Expected behavior
sysinstall event handler should pass discMapper as package name to uninstallGMS function.

Environment (please complete the following information):

• discMapper Version: /feature/uninstall-generic_mapper
• Mudlet Version: 4.9.1
• OS: win10

Describe the bug
check_version retains GMS text

To Reproduce
run check_version

Expected behavior
same but script-specific text

Screenshots

Environment (please complete the following information):

• discMapper Version: v0.3.0-beta
• Mudlet Version: 4.9.1
• OS: win10

can be found in mudlet forum

https://www.contributor-covenant.org/version/2/0/code_of_conduct

The initial bug thrown by v0.1.0 is due to a reference call to an IRE mapper routine that we forgot to take out. I have a bug fix already in another profile. Just need to find it, and apply it to the development branch.

It looks like we added an exact match for What? that Discworld sends sometimes for failed moves. The regex match already exists, but the question mark at the end is a special character and needs to be escaped.

Describe the bug
generic_mapper does not clean up after itself during uninstallation; It leaves the files in /map downloads/. discMapper's check_update function incorrectly populates the versions table from the vestigial versions.lua of the generic_mapper package that Mudlet installs by default to all new profiles.

To Reproduce
Steps to reproduce the behavior:

1. Create new profile
2. Uninstall generic_mapper
3. Install discMapper
4. Connect to Discworld

Expected behavior
Nothing. check_version should find pos = 0 on first run because discMapper pre-releases do not include a local versions.lua file.

Screenshots

Environment (please complete the following information):

• discMapper Version: 0.3.0-beta
• Mudlet Version: 4.9.1
• OS: win10

semantic-release seems really helpful, but requires some sort of workflow. right now, it might be best for me to do things manually to better understand what I might want from an automated workflow with CI.

It's getting to be that time to delve back into the code, but this time I'll be keeping track of the changes and outcomes.

Including the version number in the module's filename was intended to differentiate among versions, but it turns out that the version number in the filename cannot then be easily advanced without uninstalling, renaming, and then reinstalling the module. Renaming the folders in the edbee tree is probably an easier way of keeping track of the version number inside Mudlet for now. Maybe just 'discMapper' even though this will have redundancy in at least one case.

Describe the bug
running check_version on connect seems to have the potential to get buried in scroll during the login process. A novice user is likely not to notice the opportunity to run map update and persist with an outdated script unnecessarily.

To Reproduce
Steps to reproduce the behavior:

1. Create new profile
2. Uninstall generic_mapper
3. Install discMapper
4. Connect to Discworld
5. Scroll back in buffer

Expected behavior
Since discMapper is game-specific, maybe we can just have it triggered instead when the character inventory is regenerated.

Screenshots

Environment (please complete the following information):

• discMapper Version: 0.3.0-beta
• Mudlet Version: 4.9.1
• OS: win10

Maybe I should rewind the repo to begin with the original generic_mapper, then add the 5/24 version that @vadi2 and I made. Will it show the changes? I bet it will, and that will be good for my learning.

See https://wiki.mudlet.org/w/Mudlet_Packages

As a script writer, you can also allow people to just copy/paste a command into Mudlet to install your package - super easy. Here's a demo, paste this into Mudlet:

lua function d(a,b)if not b:find("oci",1,true)then return end installPackage(b)os.remove(b)cecho("<lime_green>Package installed!\n")end registerAnonymousEventHandler("sysDownloadDone","d")downloadFile(getMudletHomeDir().."/oci.mpackage","http://www.mudlet.org/wp-content/files/one-click-install-demo.mpackage")

To get such a line for your script, do the following:

1. Copy/paste code below to https://mothereff.in/lua-minifier

function d(_, f)
  if not f:find("oci", 1, true) then return end
 
  installPackage(f)
  os.remove(f)
  cecho("<lime_green>Package installed!\n")
end
 
registerAnonymousEventHandler("sysDownloadDone", "d")

downloadFile(getMudletHomeDir()..(URL:ends("xml") and "/oci.xml" or "/oci.zip"), URL)

2. replace the URL (the http://www.mudlet.org/wp-content/files/one-click-install-demo.mpackage bit) with your .zip, .mpackage, or .xml URL

3. find & replace all semicolons (;) with spaces ( ) in the minified version

4. prefix it with 'lua ' and paste it into Mudlet!

note: requires Mudlet 3.0 to work.

Reduce production file size to <100k. The blank .xcf can be stored in some src folder or something? ./src/images? Or, is src only for code, and not production assets? /ref/images.

I know that this might be more of a UI issue, but I'm going to set the default room color to a dark grey for streets, since the other rooms are colored with styleRooms.

Too complicated. I'm not in the headspace or at that point in my understanding of branch management here to resolve this conflict. I'll just close the PR and have ImgBot recompress the file and submit a new PR.

Originally posted by @iLPdev in #14 (comment)

Is your feature request related to a problem? If so, please describe.
If a user was previously using generic_mapper, the package itself needs to be uninstalled prior to installation of discMapper in order to avoid conflicts. generic_mapper's "whale legs" can stay in ../map downloads to preserve the user's prior saved data.

Describe the solution you'd like
Automated generic_mapper package uninstall during discMapper installation
Notify user of "whale legs" location of their old saved data - they may wish to reference prior configs.lua, map_save.dat, map.dat, and any changes they saved to generic_mapper.xml.

Describe alternatives you've considered
Manual uninstall is the current requirement for the pre-release module

This is another bug that did not show up until I loaded the scripts that @vadi2 and I made into a clean profile. I can't recall how I resolved this previously. I think it needs to be passed gmcp.room.info.name instead of whatever it's receiving that was associated with the old generic_mapper room name detection.

I don't think we need to sanitize room names anymore to begin with because the script is now pulling roomName from GMCP data. There might be other places that call sanitizeRoomName, so I'm not yet certain if it's safe to remove the entire function or not yet. If nothing else uses it, then we might as well remove it.

[  LUA  ] - error in event handler for onNewRoom:
             <[string "Script: discMapper"]:2309: map.sanitizeRoomName: bad argument #1 expected room title, got nil!>

I've been naming my commits too specifically, and other than rebase using reword there does not appear to be a way to rename them, especially after they've been pushed.

https://help.github.com/en/github/committing-changes-to-your-project/changing-a-commit-message

Is your feature request related to a problem? If so, please describe.
Unclear what was the problem that Jor'Mox was addressing with safeDelete, and if it was resolved. Sounds like the exits stubs of attached rooms are deleted, when deleting a room.

Describe the solution you'd like
Don't delete the exit stubs when a room is deleted.

Describe alternatives you've considered
Jor'mox provided an alternative as a menu addition called [safeDelete])https://forums.mudlet.org/viewtopic.php?p=44771&sid=baf30e91ed14bff7d61c48e75af6fa82#p44771)

Room styling needs a "help file" as referenced in the custom font README.md.

This was actually supposed to be exits.