ikvasnica / phpstan-clean-test Goto Github PK

Hi,
first of all - great job!

I don't understand why setup method is wrong.
If I have a test cases that works for example on Cart and Extended Warranty, while I'm testing a cart, and I want to have the Extended Warranty setup for each test same... Why not use the setup method where $this->extendedWarranty is filled in? Of course for each test case by the same setup.

I find useful to compare value objects by assertEquals because it is what I need. What is wrong with this approach?

Hi, I'm having a problem with the mentioned rule, since not all used assertions are coming from Phpunit Assert...

For example in functional tests in symfony, when using the WebTestCase, and for example the assertion assertResponseStatusCodeSame().

Maybe your Rule should check wether or not the method exists on Assert?

Hi, I've encountered this repository recently and it looks interesting 👏 . However, PHPStan v0.* is pretty outdated, so I'm asking for the v1 support 🙏 . We then might use this plugin in PHPCSFixer repo 🙂.