ijunaid8989 / extractor Goto Github PK

View Code? Open in Web Editor NEW

2.0 2.0 0.0 5.98 MB

Snapshot Extractor

License: MIT License

JavaScript 4.33% Elixir 92.65% CSS 0.08% HTML 2.94%

extractor evercam camera dropbox extract-images grabber uploader snapshot-extractor

extractor's Issues

Optimise How you get the list of snapshots

Probably by first requesting the entire list and second generating the requests.
calculate what the predicted # snapshots should be, so we know the We got XX of YY .
~~Make schedule component horizontal~~ (Reasons there is no option available for this but we can create something for our own need which is called customView https://fullcalendar.io/docs/views/Custom_Views/) UPDATE
Schedule component can default to M-F 8:00-17:30

Move all to files gathering

Optimize more! while collecting all files. Instead of checking hours and days

Find Quantum Job

In case of failure: Monitor the job, In case if it failed then send email about failure.

https://github.com/c-rack/quantum-elixir

Update the application to Phoenix 1.3

Update snapshot extractor to the lates version of Phoenix and Elixir 1.5.1

Collapse case block to header match

extractor/lib/snapshot/snap_extractor.ex

Line 104 in d4318c6

defp ambiguous_handle(value) do

Can be rewritten into:

def handle({:ok, something})

Same for this:

extractor/lib/snapshot/snap_extractor.ex

Line 191 in d4318c6

def get_ending_hour(ending_hour, ending_minutes) do

Consider using Logger except of IO.insect/1

extractor/lib/snapshot/snap_extractor.ex

Line 199 in d4318c6

IO.inspect response

Elixir has nice built in Logger. It will perform better.

https://hexdocs.pm/logger/Logger.html

It has many more advantages like compile time optimization and it has separate process.

Reduce number of clauses in with statement

https://github.com/ijunaid8989/extractor/blob/d4318c65d2fbd734db3ad234a8c6cc7b45c49f14/lib/snapshot/snap_extractor.ex#L290-291

with was designed to enable agregation of ingredients for what it returns. It can be rewritten as simply.

with
  {:ok, data} when is_something(data) do
  whatever
end

Strange issue might be from seaweedFS

2017-03-09T15:06:17.384540+00:00 app[web.1]: 15:06:17.383 [error] Task #PID<0.2611.0> started from Quantum terminating
2017-03-09T15:06:17.384543+00:00 app[web.1]: ** (CaseClauseError) no case clause matching: {:ok, %HTTPoison.Response{body: "{\"error\":\"Get http://88.99.48.9:8080/32788,c2cff08bd3729b47: dial tcp 88.99.48.9:8080: getsockopt: connection refused\"}", headers: [{"Content-Type", "application/json"}, {"Date", "Thu, 09 Mar 2017 15:06:17 GMT"}, {"Content-Length", "119"}], status_code: 500}}
2017-03-09T15:06:17.384544+00:00 app[web.1]:     (extractor) lib/snapshot/snap_extractor.ex:138: Extractor.SnapExtractor.do_loop/6
2017-03-09T15:06:17.384545+00:00 app[web.1]:     (elixir) lib/enum.ex:651: Enum."-each/2-lists^foreach/1-0-"/2
2017-03-09T15:06:17.384546+00:00 app[web.1]:     (elixir) lib/enum.ex:651: Enum.each/2
2017-03-09T15:06:17.384547+00:00 app[web.1]:     (extractor) lib/snapshot/snap_extractor.ex:59: anonymous fn/8 in Extractor.SnapExtractor.extract/1
2017-03-09T15:06:17.384548+00:00 app[web.1]:     (elixir) lib/enum.ex:1628: anonymous fn/3 in Enum.reduce/3
2017-03-09T15:06:17.384549+00:00 app[web.1]:     (elixir) lib/range.ex:92: Enumerable.Range.reduce/5
2017-03-09T15:06:17.384549+00:00 app[web.1]:     (elixir) lib/enum.ex:1627: Enum.reduce/3
2017-03-09T15:06:17.384550+00:00 app[web.1]:     (extractor) lib/snapshot/snap_extractor.ex:53: Extractor.SnapExtractor.extract/1
2017-03-09T15:06:17.384551+00:00 app[web.1]: Function: &Quantum.Executor.execute/2
2017-03-09T15:06:17.384554+00:00 app[web.1]:     Args: [{"*/2 * * * *", {"Extractor.StartExtractor", "start"}, [], :utc}, %{d: {2017, 3, 9}, h: 14, jobs: [snapshot_extraction: %Quantum.Job{args: [], name: :snapshot_extraction, nodes: [:nonode@nohost], overlap: false, pid: #PID<0.2610.0>, schedule: "*/2 * * * *", state: :active, task: {"Extractor.StartExtractor", "start"}, timezone: :

Export to PDF

An option to [ ] Export to PDF which will place the images on to a PDF template. This is in order to print flipbooks.

https://github.com/h4cc/awesome-elixir#pdf

More information

Can we specify the hours on which there was no image??

missing hours

Posible misusage of cast/4

extractor/web/models/snapshot_extractor.ex

Line 54 in d4318c6

|> cast(params, @required_fields, @optional_fields)

https://hexdocs.pm/ecto/Ecto.Changeset.html#cast/4

cast/4 changed a bit, please put all updateable fields in 3rd param.

Split the function into smaller pieces..

extractor/lib/snapshot/snap_extractor.ex

Line 4 in d4318c6

def extract(extractor) do

Usually it is a good idea to split that giant function into smaller pieces.

Pieces like these:

extractor/lib/snapshot/snap_extractor.ex

Line 36 in d4318c6

case SnapshotExtractor.update_extractor_status(extractor.id, %{status: 1}) do

They exist only for side effects and will form nice separate functions.

run each extraction

Right now extractions wait for one to complete, can they run parallel?

Hi @ijunaid8989 ,, I'm a graphic designer and an open source enthusiast. I'd like to contribute to your project by proposing a logo design and I've designed logos for your project. If you have an idea please share with me, it would be better for me. Best Regard.

4 lazy tasks, never make an issue with a title like this

https://github.com/evercam/evercam-admin/issues/256

show default on schedule
make schedule full height

https://github.com/evercam/evercam-admin/issues/255

Beautify Email templates

Can we give some styles to Email templates!

ijunaid8989 / extractor Goto Github PK

extractor's Issues

Recommend Projects

Recommend Topics

Recommend Org