Giter Club home page Giter Club logo

Comments (16)

singhpratyush avatar singhpratyush commented on September 24, 2024 1

Clicking outside is not an good idea. People may end up clicking some link in order to hide the popup, getting extremely annoyed in the process.

from college_website.

mayankpi avatar mayankpi commented on September 24, 2024 1

But the chances of clicking on any other link is very less (i.e. when the user knows very little about the browsing) but it is more annoying when it always shows until you click the tiny icon on the page.

from college_website.

RajuKoushik avatar RajuKoushik commented on September 24, 2024

But this trend is followed in every website, so it should not be a problem.

from college_website.

ansarimofid avatar ansarimofid commented on September 24, 2024

@ I think singh-pratyush96 is right!

from college_website.

singhpratyush avatar singhpratyush commented on September 24, 2024

But the popups do look annoying because you have to click again on them to close. Is there anything we can do?

from college_website.

RajuKoushik avatar RajuKoushik commented on September 24, 2024

exactly @singh-pratyush96 thats the reason I have added a js snippet to overcome it.
Its always annoying when the pop over shows up that way.

from college_website.

RajuKoushik avatar RajuKoushik commented on September 24, 2024

What do you think @ansarimofid ? Doesn't it look annoying when you have to go back to the icon to disable it?

from college_website.

ansarimofid avatar ansarimofid commented on September 24, 2024

Ya I agree @RajuKoushik .

from college_website.

singhpratyush avatar singhpratyush commented on September 24, 2024

@ansarimofid : Please verify the code in pull request #37 and take proper action.

from college_website.

RajuKoushik avatar RajuKoushik commented on September 24, 2024

The thing is it has to be changed for every page. @singh-pratyush96 @ansarimofid

from college_website.

ansarimofid avatar ansarimofid commented on September 24, 2024

Ok i will review

from college_website.

ansarimofid avatar ansarimofid commented on September 24, 2024

I saw your page https://rajukoushik.github.io/college_website/about.html.
It still has issue refer to #33 @arpit1997 comment

from college_website.

ansarimofid avatar ansarimofid commented on September 24, 2024

and why don't you use class instead of using id for each link.

from college_website.

RajuKoushik avatar RajuKoushik commented on September 24, 2024

@ansarimofid I have updated the code with a new pull requests which does not have such issues(regarding #33rd issue) and using js classes. You can review it now.

from college_website.

ansarimofid avatar ansarimofid commented on September 24, 2024

great work @RajuKoushik . Now you have great task of updating all the pages with the code of popover.

from college_website.

singhpratyush avatar singhpratyush commented on September 24, 2024

We have to look @ #40 now for things related to popover. Closing.

from college_website.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.