Comments (16)
Clicking outside is not an good idea. People may end up clicking some link in order to hide the popup, getting extremely annoyed in the process.
from college_website.
But the chances of clicking on any other link is very less (i.e. when the user knows very little about the browsing) but it is more annoying when it always shows until you click the tiny icon on the page.
from college_website.
But this trend is followed in every website, so it should not be a problem.
from college_website.
@ I think singh-pratyush96 is right!
from college_website.
But the popups do look annoying because you have to click again on them to close. Is there anything we can do?
from college_website.
exactly @singh-pratyush96 thats the reason I have added a js snippet to overcome it.
Its always annoying when the pop over shows up that way.
from college_website.
What do you think @ansarimofid ? Doesn't it look annoying when you have to go back to the icon to disable it?
from college_website.
Ya I agree @RajuKoushik .
from college_website.
@ansarimofid : Please verify the code in pull request #37 and take proper action.
from college_website.
The thing is it has to be changed for every page. @singh-pratyush96 @ansarimofid
from college_website.
Ok i will review
from college_website.
I saw your page https://rajukoushik.github.io/college_website/about.html.
It still has issue refer to #33 @arpit1997 comment
from college_website.
and why don't you use class instead of using id for each link.
from college_website.
@ansarimofid I have updated the code with a new pull requests which does not have such issues(regarding #33rd issue) and using js classes. You can review it now.
from college_website.
great work @RajuKoushik . Now you have great task of updating all the pages with the code of popover.
from college_website.
We have to look @ #40 now for things related to popover. Closing.
from college_website.
Related Issues (20)
- Update admissions page
- Adding Google Calendar HOT 2
- Fix Navbar HOT 1
- Google Map HOT 1
- The website could be written more Effectively and Consistently. HOT 1
- Pop ups of the address, phone no. and email should disappear by clicking anywhere on the page not just the icons. HOT 3
- Drop down menu of the navigation bar disappears after clicking. HOT 3
- Adding content to 'Announcements' section on home page HOT 2
- Corousel images getting apart @ 2400px width. HOT 1
- Add 'Invited Talks' page. HOT 1
- Fade scrolling in announcements and news HOT 2
- Add invited talks to more section.
- Add more faculty pages.
- Add Photo Gallery Page HOT 1
- Add Gallery Link to navbar HOT 1
- Add caption to Gallery Images of gallery pages HOT 2
- Add photo gallery to navigation of each page.
- Committees Link HOT 1
- Placement Information HOT 1
- 55
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from college_website.