ihiutch / draft-ui Goto Github PK

React Aria actually does something pretty clever that I think we can do too: https://react-spectrum.adobe.com/react-aria/SearchField.html#composed-components

Because many of their components are composed from more primitive components, I think it would be interesting to do something similar. The goal would be to link back to the React Aria docs, but as Im typing this it also interesting to think about doing something similar to their docs with the Draft UI docs. Where something like the Search Component links back to the Button, Label, and Input components. 🤔

There seems to be a small visual bug when site navigation links are focused:

See screenshot for example:

If we apply pl-3 (we apply pr-3 to each <LinkList /> already) then the focused state would no longer be cut off.

Any thoughts? Happy to make a fix for this if we think it makes sense 👍

Breadcrumb items wrap <Link /> but the examples are passing <a> as a child so what ends up happening is you actually get nested anchor tags which I don't think is what's intended.

Happy to raise a PR to fix this if you agree that this is a bug.

Update code example theme to look nicer with the tailwind color scheme that's used on the docs

Do you plan on having a multi-select?

This one of the reasons I'm looking at alternatives to ShadCN (NextUI got a nice one)

These were skipped because I wasn't comfortable with how I grouped the Date components imports. However, the DatePickers depend on these components and they're not currently documented.

Hi 👋🏻

Saw this component library in a Tweet on my timeline and took a quick look as always great to see new projects pop up. Looks great so far, keep up the great work! 🙌🏻

Found a small visual bug with ComboBox where the background only extends to the height of the viewport and therefore if the viewport height is tiny the items in the ComboBox extend beyond the background, which looks a bit 💩.

Did my best to highlight the bug in the screenshot below.

This is in Chrome v112 on macOS, just in case it's browser or platform specific.

Hope this helps 😃

My biggest concern here is that I don't like the idea of having to use CSS variables or theme config to manage a theme. This feels like an unnecessary overhead that I found to be fairly complicated when trying to customize these components beyond changing a few colors. My original intention was to make it easy to get started building accessible interfaces and an additional step of configuring a theme or having to rip it out altogether seems like it would hurt more than help.

Then again, maybe being able to customize just enough makes Draft UI more appealing to use in the first place and/or easier to manage with a CLI installation tool.

I'd be curious to see what folks think.

Based on this: https://twitter.com/roguesherlock/status/1740948313858580652?t=0d4ByvaUnHpcTks2As9VsA&s=19

Hi there,

I just found your project, and it looks great, but what is the license on the project?

Cheers,
Erik

Currently, left button decreases and right increases

A CLI for "installing" things would be nice. And could be relatively easy by using Sly CLI by @jacobparis. That comes with the benefit of sharing the maintenance burden as well.

Thoughts on a collaboration here?

Right now, full length code examples have a min height so they're scrollable. I think they may look a bit nicer if they're truncated/hidden by default and toggled to open taller or full-height. Similar to the shadcn/ui manual installation examples.