Game crash during AI turn on failed assertion on _pathStart about fheroes2 HOT 4 CLOSED

Hi @idshibanov and @oleg-derevenetz , I would like to hear your opinion about a possible solution. One of them to simply add _enemyArmies.erase( tileIndex ); but I have a feeling it is not a proper solution. What do you think?

from fheroes2.

I can make a PR with the workaround I mention, or we may look for another solution (maybe update _enemyArmies on a hero being dismissed, assuming I correctly understood what happens ?)

from fheroes2.

We root cause of this assertion is that we do not update priority targets properly for AI after the action within Normal::updatePriorityTargets() method. More specifically, _enemyArmies is not updated. We must erase tile ID after capturing a town which we don't do. In this example the AI tries to clear a DEFEND task under if ( hero.GetIndex() != tileIndex ) { condition. I think this comment is not valid:

// Either the castle has just been captured, or the hero meets the guest hero of a friendly castle. No task should be updated.
// If any of these assertions blow up, then this is not one of these cases.

from fheroes2.

It looks like a regression from #7379.

from fheroes2.