igorkulman / kulman.wpa81.baserestservice Goto Github PK

Ditch SymbolSource.org and use GitLink instead

I'm using an API returning a 400 StatusCode (Bad Request) but I need the response content because the API store the error message there.

With the default EnsureSuccessStatusCode I don't have the information.

https://github.com/igorkulman/Kulman.WPA81.BaseRestService/blob/master/Kulman.WPA81.BaseRestService/Services/Abstract/BaseRestService.cs#L421

I've a fix and I'll create a pull request

Add better check for absolute vs relative url at https://github.com/igorkulman/Kulman.WPA81.BaseRestService/blob/master/Kulman.WPA81.BaseRestService/Services/Abstract/BaseRestService.cs#L240

Would be nice to log all the requests with their parameters so the user code can see it while debugging.

The idea is to be able to get all the response headers when using POST, GET, PATCH, PUT.

There are two possible approaches that come to mind

• add optional out / ref parameters to the methods for setting response headers
• create new methods returning some structure that contains the response headers and the actual deserialized response

Add CancellationToken as an optional parameter to all HTTP methods and make it work as expected.

Is there a reason to have a separate UWP package? The WPA81 package works fine in UWP projects.

Better unit tests are needed to cover all the functionality. A server with suitable endpoints needs to be found or written.

As I can see there is only on method delete

protected Task Delete([NotNull] string url)

I'm using an API returning a json response from a Delete and it could be nice to have a delete signature like this :

protected Task<T> Delete<T>([NotNull] string url)

The idea is to add an interface, something like ICache that the REST service will use for response caching. Caching can be done according to time, ETag, etc. depending on the ICache implementation.

The library should also include a sample implementation of this interface, for example memory or local storage caching.

The Jetbrains.Annotations binary dependence needs to be removed and the annotations should be make visible to the outside world.