Giter Club home page Giter Club logo

Comments (7)

jonpas avatar jonpas commented on July 18, 2024 1

I can clearly hear and understand the voices in your recordings.

Do you have a known hearing condition? It could also be your audio equipment. Have you tried playing back those recordings on your phone?

from acre2.

LuckyOwl1364 avatar LuckyOwl1364 commented on July 18, 2024

Oh interesting: in the file FilterRadio.cpp is a check on a getter getDisableRadioFilter() that skips the audio-filtering process:

if (CAcreSettings::getInstance()->getDisableRadioFilter())

that is set to false by default in AcreSettings.cpp:
m_DisableRadioFilter(false),

but does not look like it checks for a config change when fetching all the other configs higher up in the file. Is there a way to change m_DisableRadioFilter's value other than this setting of a default? Ideally I want to do this client-side not server-side

from acre2.

LuckyOwl1364 avatar LuckyOwl1364 commented on July 18, 2024

Further investigations: it seems like the main culprits for speech being unintelligible to me may be the white noise and pink noise mixed in. I see in FilterRadio.cpp


they can be toggled with the noise parameter, which comes from RadioEffect.cpp:
https://github.com/IDI-Systems/acre2/blob/master/extensions/src/ACRE2Core/RadioEffect.cpp#L15

noise gets set by getParam("disableNoise"), which I can't seem to find in the repo (though admittedly my IDE is not indexing this repo very well for some reason). If I could toggle that param in a reachable way, that could solve my problem 🤔

from acre2.

LuckyOwl1364 avatar LuckyOwl1364 commented on July 18, 2024

Really? It's hard for me to understand the first clip, and for the second clip, the first person talking is entirely unintelligible to me (the second person is somewhat understandable).

I have audio processing issues, so while my ears can pick up that a radio transmission is playing, I can't parse what is being said through the noise applied to the audio :( . If I could turn off the white noise and pink noise on my client, that could be enough to make things understandable.

from acre2.

rautamiekka avatar rautamiekka commented on July 18, 2024

No problems in the 1st one for me either (couldn't understand the words in the latter), which sounded the same with my Android 14 tablet's speakers as always did with my HyperX-something headset on my Win10 laptop, so I agree with @jonpas.

from acre2.

jonpas avatar jonpas commented on July 18, 2024

Really? It's hard for me to understand the first clip, and for the second clip, the first person talking is entirely unintelligible to me (the second person is somewhat understandable).

I have audio processing issues, so while my ears can pick up that a radio transmission is playing, I can't parse what is being said through the noise applied to the audio :( . If I could turn off the white noise and pink noise on my client, that could be enough to make things understandable.

Yeah, that's why I was very confused at first. But it makes sense and of course, we are willing to accept settings to make it usable for you as well.

from acre2.

LuckyOwl1364 avatar LuckyOwl1364 commented on July 18, 2024

Thank you! It means a lot that you hear out accessibility issues. I'd be happy to put some work in to implement a toggle setting in the in-game addon config menu or something if that would help :)
(Not that I've modded games or made UIs before but in general coding I could help)

from acre2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.