idelvall / nand-mines Goto Github PK

Could you please add a test for 0000 0000 0000 0001 and ensure it is coded as ~32767 instead of -32768 since -32768 is not a valid input value in Jack.
The problem is that -32768 generates the VM code:

push 32768
neg 

which in turn produces the assembly command

@32768

which fails because the binary for an @ command is 0 followed by a 15 bit value and 32768 uses the 16th bit.

Eg.a quick fix would be to insert at line 163:

if (value == -32768) 
    generateCode.value = generateCode.value + "\tdo Memory.poke(memAddress+" + row*32 + ", ~32767);\n"; 
else
    generateCode.value = generateCode.value + GenerateCodeLine(i, value);

and delete line 164. Or the same test could be moved to the GenerateCodeLine function.

Note that this is a bug in the original version of the Sokoban bitmap editor also.