idealista / prometheus_server_role Goto Github PK

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
  • Checked that there is not already provided the described functionality

Description

Prometheus 2 was released on November 2017 and could be interesting to discontinue our support to previous versions (in order to have the role cleaner and make the Travis tests faster). Plus, maybe we should update the role default version to the most updated one (2.6.1 at this moment) as well

Include CI and contribution files

Prerequisites

• [ X] Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
  • Checked that there is not already provided the described functionality

Description

Right now the rules are being copied to the host using the 'copy' module instead of prev used 'template'.
So it's not neccessary to still use the templates folder

Expected behavior: Use files folder (at least change to prometheus_rules_files_path) in the copy/rsync rules task

Actual behavior: Copy/rsync task is using prometheus_rules_templates_path

Reproduces how often: Always

Versions

1.3.1

Description

It would be great to add support for making tuning when you configure a remote write endpoint to storage data in a third-party long-term storage.

Why is this needed?

Basically, for memory usage tuning.

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
  • Checked that there is not already provided the described functionality

Description

Sorry for the catchy title. Sometimes the reload handler fails, but it actually succeeds reloading Prometheus. Problem is that, in big instances, sometimes it takes more than 30 seconds to respond. Rising the timeout will fix the problem.

Prerequisites

[* ] Put an X between the brackets on this line if you have done all of the following:
* Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
* Checked that there is not already provided the described functionality

Description

Enable Prometheus Server 2.0 configuration.
Provide support for older versions is a must :)

Description

[Description of the issue]

Automatic removal of old scrape files that are not in the playbook anymore.

Why is this needed?

[A clear and concise description of why do you think this is needed]

If you want to remove an old scrape file from your prometheus server, you have to manually remove it in the server.
Removing it from your playbook and running it is not enough.
With this implementation, that process would be made by ansible by running your playbook.

Additional Information

[Any additional information, configuration or data.]

Description

To solve the idempotency of abv-monitor-playbook it is necessary to match the path of the prometheus user shell as the rest of the roles on which it depends:

• Change /sbin/nologin to /usr/sbin/nologin and set it as a variable.

Why is this needed?

So the role is updated along all the roles

Additional Information

N/A

Description

Every week the Travis build fails because of a Pipenv error: https://app.travis-ci.com/github/idealista/prometheus_server_role. We should fix this.

Steps to Reproduce

N/A

Environment

Reported in travis

Additional Information

N/A

It would be great to pass the variables in a config file to make the start script more flexible

Description

If both handlers are triggered, Prometheus will first restart and then reload. If Prometheus doesn't restart quick enough, the second handler will fail and that can cause an innecessary play interrumption.

Prerequisites

• [X ] Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
  • Checked that there is not already provided the described functionality

Description

Add test-requirements.txt in order to make easier the tests launch. In additon, you could launch the tests with pipenv.

Steps to Reproduce

Expected behavior: [What you expect to happen]

Actual behavior: [What actually happens]

Reproduces how often:

Versions

1.4.0

Additional Information

Any additional information, configuration or data that might be necessary to reproduce the issue.

Description

Currently, this role does not provide any mechanism to check if the Prometheus config files are correct. They can be checked in Molecule's verify with promtool, but this option does not provide enough information as the Prometheus service won't boot, failing the playbook in the converge stage.

It would be interesting to check those files with promtool before the copy.

Why is this needed?

In order to provide more descriptive information about bad configured alerts and etc

Additional Information

It would be interesting to try promruval

Description

In some servers it gets stuck when reloading after a change in the rules. It can be solved by stop using the reload handler and only use the restart handler, which works well.

Steps to Reproduce

1. Playbook with changes in rules
2. When it tries to reload does not end

Expected behavior:
To work after changing the rules

Actual behavior:
Gets stuck reloading after change in rules

Reproduces how often:
Only on some servers

Environment

• The release version/s you are using: 1.10.1
• OS: debian 9/10

Additional Information

N/A

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
  • Checked that there is not already provided the described functionality

Description

The current version of this role uses vagrant for testing. We must move to docker in order to standarize this role. And, by the way, we'll upgrade molecule version and rename role in order be Galaxy compliant.

Versions

All.

Description

Templates with custom jinja delimiters instead of copy for rules

Why is this needed?

To use conditionals using jinja templates. E.g. different contents in rules file depending if the environment is production or staging

Additional Information

N/A

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
  • Checked that there is not already provided the described functionality

Description

Add option to configure remote_url and remote_write code blocks in prometheus.yml

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
  • Checked that there is not already provided the described functionality

Description

Due to the ">" in https://github.com/idealista/prometheus_server-role/blob/master/templates/prometheus.service.j2#L11, every time Prometheus is restarted it overwrites prometheus.log. It should be replaced with ">>" so it appends the new output to the previous log file.

Steps to Reproduce

1. Watch prometheus.log file.
2. Restart Prometheus with systemctl restart prometheus.service
3. Watch prometheus.log file.

Expected behavior: See both restarts.

Actual behavior: Only last restart appears.

Reproduces how often: Always

Versions

All.

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
  • Checked that there is not already provided the described functionality

Description

Are there plans to make this role support yum / rpm based systems?