icidasset / elm-material-icons Goto Github PK

Icons were updated. Noticed that contactless was added, probably a few others as well.

This is what the README.md says:

Looks like the Github repo was recently updated:

Might be a good idea to take a look at it?

The icon is listed on material.io here.

Quick question, in the latest version of this library the shared types have been removed. This caused us to no longer be able to integrate the package with our internal color module as we now need to provide a helper function to convert each type of icon color. Would you consider moving back to a shared type module for colors? Thanks!

Here's an example of what we use to have:

toMaterialIcon : Element.Color -> Coloring
toMaterialIcon color =
    color
        |> toColorLibColor
        |> Material.Icons.Color

-- Convert elm-ui color to avh4/elm-color
toColorLibColor : Element.Color -> Color
toColorLibColor color =
    let
        rgba =
            Element.toRgb color
    in
    Color.rgba rgba.red rgba.green rgba.blue rgba.alpha

Hi started using your library, great work.
I think there is a small error in your about docs:

Filled.offline_bolt 16 (Color <| Color.rgb 96 181 204)

Color.rgb only accepts floats between 0 and 1 - for your example to work you need Color.rgb255

Not a big deal :)

Would it be possible for the library to embed icons in the docs so developers can preview what they are importing.

Another library (FeatherIcons) I have been looking into implements this and its been a delight to use.

For example:

They are doing this by providing an image in the docs like this:

{-| align-right
![image](data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHdpZHRoPSIyNCIgaGVpZ2h0PSIyNCIgdmlld0JveD0iMCAwIDI0IDI0IiBmaWxsPSJub25lIiBzdHJva2U9ImN1cnJlbnRDb2xvciIgc3Ryb2tlLXdpZHRoPSIyIiBzdHJva2UtbGluZWNhcD0icm91bmQiIHN0cm9rZS1saW5lam9pbj0icm91bmQiPjxsaW5lIHgxPSIyMSIgeTE9IjEwIiB4Mj0iNyIgeTI9IjEwIj48L2xpbmU+PGxpbmUgeDE9IjIxIiB5MT0iNiIgeDI9IjMiIHkyPSI2Ij48L2xpbmU+PGxpbmUgeDE9IjIxIiB5MT0iMTQiIHgyPSIzIiB5Mj0iMTQiPjwvbGluZT48bGluZSB4MT0iMjEiIHkxPSIxOCIgeDI9IjciIHkyPSIxOCI+PC9saW5lPjwvc3ZnPg==)
-}
alignRight : Icon
alignRight =
    ...

Why do this?

• Developer Experience

Why not do this?

• Even larger source code (I noticed the base material libraries is 1.3MB); this is a one time download so maybe its okay
• A potentially more complex generation process; this might not be true since you start with the svg and could just base64 encode it into the docs
• The google icons website might already be adequate for previewing

What do you think @icidasset?

Oh, and thanks for the wonderful library!

https://github.com/material-icons/material-icons

Add an example of how to use Icon within Html.