Giter Club home page Giter Club logo

cinny's Introduction

Welcome visitor



cinny's People

Contributors

ajbura avatar alch-emi avatar anyone00 avatar c0ffeecode avatar cremesk avatar daemonspring avatar deanveloper avatar dependabot[bot] avatar empty2k12 avatar ginnythecat avatar jamesjulich avatar jameskitt616 avatar kfiven avatar l-as avatar mjarr avatar mkljczk avatar morguldir avatar moritzdietz avatar nitanmarcel avatar notjustinshaw avatar phildenhoff avatar renovate[bot] avatar rubinelezi avatar samueldr avatar shadowjonathan avatar steffo99 avatar thebluematt avatar thumbscrew avatar troplo avatar zalaxx avatar

cinny's Issues

Minor bug - Call unexpected reconnect if home screen is empty

Describe the bug

Hi there IceDBorn,

Hope you are well, I tested your fork with implemented jitsi calling for Cinny on https://cinny.alfonso.top/ and am pleased how well it works, excellent work! It is perfectly usable aside from minor bugs.

There is an unexpected reconnect to the jitsi call if the home screen is empty, please see steps to reproduce.

If you need any further info please let me know,

Thanks,

Spacur

Reproduction

  1. Ensure that your home section has no text channels or voice channels whatsoever therefore ensuring that you receive the "Welcome to Cinny" splash screen.
  2. Create a voice channel within a pinned space.
  3. Join said voice channel.
  4. Disconnect from voice channel.
  5. Navigate back to Home section. (Does not matter if you navigate to text channels or direct messages as an intermediate step)
  6. You will rejoin the voice channel without any warning, it will take up all the space where the splash screen is expected. The splash screen does not appear to be visible in the background.

Expected behavior

  1. Ensure that your home section has no text channels or voice channels whatsoever therefore ensuring that you receive the "Welcome to Cinny" splash screen.
  2. Create a voice channel within a pinned space.
  3. Join said voice channel.
  4. Disconnect from voice channel.
  5. Navigate back to Home section.
  6. You are greeted with the standard "Welcome to Cinny" splash screen.

Platform and versions

1. OS: Windows 10 (22H2)
2. Browser: Librewolf (Firefox 114.0.1-2)
3. Cinny Version: Fork provided at https://cinny.alfonso.top/ on 08/08/2023
4. Matrix Homeserver: matrix.org

Additional context

I understand eventually that the Cinny developers will implement voice calling in their way and natively with Matrix's VOIP features, however despite several months since your fork it appears no certainty as of when. Right now your fork is 95% viable for use as a temporary workaround which is excellent and it seems a little more work would make it 100% viable.

I'm not that familiar with web technologies but when I can I'll take a look into this further.

Minor bug - Call unexpected reconnect if still focused on voice channel

Describe the bug

Hi there IceDBorn,

Hope you are well.

There is an unexpected reconnect to the jitsi call if you are still focused on the voice channel, please see steps to reproduce.

If you need any further info please let me know,

Thanks,

Spacur

Reproduction

  1. Create voice channel.
  2. Connect to voice channel.
  3. Disconnect from voice channel, you are still focused on the voice channel on the left hand side and on the right hand side it is blank.
  4. Navigate to Direct Messages or to Home (if the voice channel is in a pinned space) or to a pinned space (if the voice channel is in Home)
  5. Navigate back to the place where the voice channel resides.
  6. The voice channel is still focused and you are automatically reconnected to the call without any notification or warning.

Expected behavior

  1. Create voice channel.
  2. Connect to voice channel.
  3. Disconnect from voice channel, focus is automatically changed to go back to the previous text channel OR if your previous text channel focus was in a different space etc. perhaps just the first text channel within that space in the list? Something of the sort to ensure focus is diverted.
  4. Navigate to Direct Messages or to Home (if the voice channel is in a pinned space) or to a pinned space (if the voice channel is in Home)
  5. Navigate back to the place where the voice channel resides.
  6. As focus is changed this issue no longer happens.

Platform and versions

1. OS: Windows 10 (22H2)
2. Browser: Librewolf (Firefox 114.0.1-2)
3. Cinny Version: Fork provided at https://cinny.alfonso.top/ on 08/08/2023
4. Matrix Homeserver: matrix.org

Additional context

I have not looked at all the source code however it seems from this bug and the previous bug I've reported, you are sent the confirmation only upon clicking to enter the matrix room and not in the code which enters you into the jitsi call.

Perhaps it would make more sense to move the join confirmation prompt just before the jitsi call join code to ensure no matter what you will be prompted beforehand if I am understanding this correctly.

Feature request - Jitsi calls associated within text channels and direct messages.

Describe the problem

Voice channels are working basically exactly as expected, which is excellent.

However there is no support currently for calling within text channels or direct messages.

Describe the solution you'd like

I'd love to be able to optionally associate Jitsi calls with text channels and direct messages, perhaps a calling icon which can be used to start a call and it is situated next to the people toggle/hamburger icon at the top right of the chat.

A notification would be sent to all members within the text channel with active users having a popup to accept or deny the call and a ringtone, similar to how most calling supported applications do it. I'm not sure how complex this would be though as then you'd need to be able to send and receive call requests ontop of all the Cinny stuff.

An alternative simpler solution would be that pressing the call icon would connect you to the jitsi call and send a message to inform people you have started/joined the call within the text chat or direct message it was started in so then they can press the call icon to connect on their end. I'm assuming how jitsi works here but the message could also include a jitsi invite URL to allow non jitsi call cinny fork clients and other completely different matrix clients to be able to access your call also (Of course at the drawback of it being non embedded in a separate/dedicated browser tab).

Alternatives considered

No response

Additional context

No response

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.