ianmjones / options-pixie Goto Github PK

The form currently relies on the inbuilt form security nonces, it should use a custom nonce that can be verified.

Does not seem to break functionality.

WP 4.3 has issues when the primary column is not the first column while being shown in mobile mode, an easy fix is to make sure the primary column (Option Name in our case) is the first column.

This would also be a good time to make the Option Name column the default sort order as it will be the first column, most people will be looking at this field and so it makes sense to have it sorted by default.

Only "S" is shown.

Automated Travis CI building will help ensure unit tests are not failing and that the plugin builds without errors.

If a record has been deleted after display, trying to expand the serialized option value produces this error.

Multisite:

Single Site Install:

The readme is very minimal at present and needs a much better description of what Options Pixie offers.

Should also update tags, for definite add "wp_options".

It used to be H2, but from WordPress 4.3 the titles of admin pages are now using the H1 tag.

At present Options Pixie can only determine if data has been Base 64 encoded if the contained data is Serialized, JSON or an Object.

It should be possible to test straight Base 64 encoded strings too.

After entering a new search term into the search box and submitting, the page refreshes and links are showing the new "s" term correctly, but the page's URL includes the old search term.

When the unit tests run against WordPress 3.9 they fail as the trunk of the WordPress unit test libs are no longer compatible with WordPress 3.9.

Unit tests should pull version specific branch of unit test libs.

See https://make.wordpress.org/core/2015/08/08/list-table-changes-in-4-3/

Support what we can but still try and keep compatibility back to WordPress 3.9 if possible.

At present Options Pixie shows any HTML as is, which nice, but not secure as an option_value of "<script>alert('xss')</script>" will be run and show the alert.

WordPress does have security in place that would counter attempts to meddle with the server, and Options Pixie does not enable any destructive callbacks, but it's best not to tempt fate.

See https://make.wordpress.org/core/2015/07/24/multisite-focused-changes-in-4-3/

Need to add far more details to repo readme to help developers get started etc.

For example, searching for "s:39" (without quotes) will cause redirect loop.

The core classes for manipulating data should be covered by unit tests.

The JavaScript and CSS should only be enqueued when on the Options Pixie page.

1. Install Options Pixie for first time on a multisite, or remove *options_pixie_options records from usermeta table.
2. Visit Options Pixie page via Settings -> Options Pixie menu option.
3. Change site from site selector dropdown.
4. Use "Switch Site" button.

Expect: Page refreshes and data from selected subsite shown and selected subsite shown in site selector.
Actual: Page refreshes but data from default subsite shown and still selected in site selector.

Using the "Switch Site" button from then on works as normal, even on return to page.

If any other search or sorting performed before first use of "Switch SIte" problem does not manifest.