Giter Club home page Giter Club logo

virocms's People

Contributors

ialexpw avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

Forkers

piterskiy 7ife aeimi

virocms's Issues

Duplicate the same permission check (create-user.php)

app\tpl\create-user.php

   # Permissions
    if(!Viro::Permission('users')) {		# 1
        Viro::LoadPage('access');
    }

    global $l;
    $Connect = Viro::Connect();

    # Permissions
    if(!Viro::Permission('users')) {		# 2
        Viro::LoadPage('access');

Performing the same verification twice. Probably a mistake

Logical flaw when checking for available updates

app\viro.app.php

       /**
         * Viro::CheckUpdate()
         * Check if updates are available using Viro::Version() and the website
         */
        public static function CheckUpdate() {
            # Get the current version
            $getVer = file_get_contents('https://viro.app/version.txt');		# 1

            # Get our version
            $locVer = explode('-', Viro::Version());
            $locVer = str_replace('v', '', $locVer[0]);

            # true = update available
            if($getVer != $locVer) {							# 2
                return true;
            }else{
                return false;
            }
        }

When version.txt [1] is not accessible (as it is at the moment) condition will return true [2] suggesting that there is a new version to download, and in fact there was no correct version comparison at all. In case of unavailability of resources, further comparsion makes no sense

[Security] access to the database via an Internet browser

In the default configuration, access to the database is possible from the level of a web browser, and thus obtaining the password hash for the administrator and other users:

http://server.tld/app/db/viro.db

It is suggested to move the database under docroot so that access uusing browser won't be possible.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.