The argumentativefilters from hwoodiwiss

Hi, I'm Hugo 🦀

Professionally I'm a primarily back-end developer using dotnet on AWS.

Aside from that I love C++ and Rust, and enjoy Embedded Systems, Security and Graphics programming.

Stats

argumentativefilters's People

Contributors

Stargazers

Watchers

argumentativefilters's Issues

Add "Argument ref" parameters

From looking at the example in the README, it looks like a nice feature would be to have an attribute that could only be used with a ref parameter.

So the example would become this:

public static partial class ExampleFilter
{
    [ArgumentativeFilter]
    public static ValueTask<object?> NormalizeParameterCase(EndpointFilterInvocationContext context, EndpointFilterDelegate next, [ArgumentRef] ref string parameter)
    {
        parameter = parameter.ToUpperInvariant();
        return next(context);
    }
}

The code gen would ref return the value from the context.Arguments array behind the scenes, reusing the existing IndexOf functionality.

Does not add `using`s for provided types

At the moment, using aren't being added to the generated factory code for the types provided in the filter.

This will cause build errors an all but fairly trivial cases.

Example with annotated failures:

// <auto-generated/>
using global::System;
using global::Microsoft.AspNetCore.Http;

#nullable enable

namespace SomeNamespace.Filters
{
    public static partial class SomeRequestValidationFilter
    {
        public static EndpointFilterDelegate Factory(EndpointFilterFactoryContext context, EndpointFilterDelegate next)
        {
            int? argumentNameIndex = context.GetArgumentIndex("argumentName");
            if (argumentNameIndex.HasValue)
            {
                return invocationFilterContext => {
                    var applicationOptionsService = invocationFilterContext.HttpContext.RequestServices.GetService<SomeOptions>(); <- This fails, missing Microsoft.Extensions.DependencyInjection and namespace for SomeOptions
                    var requestContextService = invocationFilterContext.HttpContext.RequestServices.GetService<SomeRequestContext>(); <- This fails, missing Microsoft.Extensions.DependencyInjection and namespace SomeRequestContext
                    var clientContextService = invocationFilterContext.HttpContext.RequestServices.GetService<SomeClientContext>();
                    var someApiOptionsService = invocationFilterContext.HttpContext.RequestServices.GetService<SomeApiOptions>();
                    string argumentValue = invocationFilterContext.GetArgument<string>(argumentNameIndex.Value);
                    return Filter(invocationFilterContext, next, applicationOptionsService, requestContextService, clientContextService, someApiOptionsService , argumentValue);
                };
            }

            return next;
        }

        private static int? GetArgumentIndex(this EndpointFilterFactoryContext context, string argumentName) 
            => context.MethodInfo.GetParameters().FirstOrDefault(p => string.Equals(p.Name, argumentName, StringComparison.Ordinal))?.Position;
    }
}

Recommend Projects