huwwynnjones / oci_rs Goto Github PK

Currently, you are using empty enums to represent the OCI opaque handle structs, such as Env. According to official Rust documentation, this is a bad idea.

From the Rust nomicon:
"Notice that it is a really bad idea to use an empty enum as FFI type. The compiler relies on empty enums being uninhabited, so handling values of type &Empty is a huge footgun and can lead to buggy program behavior (by triggering undefined behavior)."

See here: https://doc.rust-lang.org/nomicon/ffi.html#representing-opaque-structs

When trying to compile a simple application (the hello world stub) with oci_rs = "0.3.1" I am getting the following error:

   Compiling oci_rs v0.3.1
error[E0283]: type annotations required: cannot resolve `std::string::String: std::convert::From<&_>`
   --> /Users/dima/.cargo/registry/src/github.com-1ecc6299db9ec823/oci_rs-0.3.1/src/types.rs:123:17
    |
123 |         let s = String::from(self.as_ref());
    |                 ^^^^^^^^^^^^
    |
    = note: required by `std::convert::From::from`

Program compiles if I comment out the implementation of ToSqlValue for String:

impl ToSqlValue for String {
    fn to_sql_value(&self) -> SqlValue {
        let s = String::from(self.as_ref());
        SqlValue::VarChar(s)
    }
}

when oci environment is not ready.
program will fail in loop in oci_error.rs:110.
and never break the loop.

If the database has the local set up with 12 hour clock then date fields are not accepted correctly.

This is because date strings are used to create oracle dates. This is subject to changes in the format accepted by the database.

Better solution is to create dates in their binary format instead. On the to-do list.

Hello !
In oci_errors, fn get_error the loop can be infinite when error occurs while trying to get the db error.
I think in match, it should break the loop for ReturnCode::Error and ReturnCode::InvalidHandle cases...

In my platform (fedora) it loops infinitly

Hello everyone, I can't solve this.

[dependencies]
oci_rs = "0.8.0"
rustc 1.40.0 (73528e339 2019-12-16)

Allow the SQL DATE type to be used