huuphuoc1396 / android-nimble-surveys Goto Github PK

As a side note, the page indicator update logic seems to be a bit flaky that when scrolling from left to right, it won't update until the page is locked on the next page. However, in the opposite direction, it updates immediately when the scrolling first started. Lastly, the scroll sometime jumps multiple pages when scrolling in a fast manner:

• Implement the login page.
• Implement the OAuth authentication including the storage of access tokens.
• Implement the automatic usage of refresh tokens to keep the user logged in using the OAuth API.

Hello Phuoc 👋 , thank you for your effort on the code submission. I am Mike, Engineering Lead at Nimble, and I am happy to be the reviewer for our code review session.

During the review process, I would like to know more about your decisions, so I will create issues in some areas where there could be more improvements regarding your submission. Since solving every possible problem would take too long, I will prioritize the most important ones.

At the same time, please keep in mind that this is a bi-directional process, and I would love to hear back from you as well. Therefore, do not hesitate to ask questions or share your opinions about the implementation (if any) during the process.

We expect the code review process to be completed within 2-3 days. As a result, please make sure you are responsive during this process. If you need more time, please let us know as soon as possible so we can plan accordingly.

If we are aligned on any issue, and you would like to correct them, please address the issue using a proper git flow (creating a new branch, opening a Pull Request (PR) per issue, and merging the code when you are ready), and I will follow up on those fixes. Just so you know, you don't have to close any of my created issues after merging your PRs; I will help verify and close them for you once they pass. 😇

In the end, I do hope that you find the process enjoyable. Good luck and happy coding. 🤘

• Create a new empty activity project
• Support Android 5.0 (API 21) and up
• Use Kotlin language.

On the home screen, each survey card must display the following info:

• Cover image (background)
• Name (in bold)
• Description

There must be 2 actions:

• Horizontal scroll through the surveys.
• A button “Take Survey” should take the user to the survey detail screen.

It is nice to see that you are trying to encapsulate the client's id and secret in a cpp library called native-lib, which can potentially protect the sensitive information during app's runtime. However, these credentials are still exposed in git versioning:

Your speed of submission is appreciated, but as a reminder, we would also love to see development driven with the least compromisation, too.

• Implement app module
• Implement data module
• Implement domain module

Issues

This is one of our original requirement on the indicator list's behavior:

In fact, while you did implement pagination loading with androidx.paging under the hood, the indicator count always shows the full total data from the API regardless of the currently loaded survey items from the API responses.

At the same time, the application needs to show the survey list after loading all the data with a valid logged-in session like the design. Currently, there are multiple UI problems with a survey item on the Home screen:

• The display image for each survey item is very blurry:
  

• For survey images with transparent background, it has an overlapping issue with the default onboarding background image:
  

• The page indicator UI has overlapping issue with the survey title when its content span over 2 lines:
  

Expect

• You need to make sure and follow the requirements correctly for the navigation indicator list (bullets) that must be dynamic and based on the API response.

• The survey item should look clearer and has no overlapping issue like the design:
  

Issue

The application needs to show the initial shimmer loading view with animation after first entering the app with a valid logged-in session. Currently, there is no proper shimmer loading animation, just a native spinning indicator, which does not match the design.

Expect

The animation for the skeleton loading view must be implemented like the following design with a correct animation that glows repeatedly transitioning from left to right.

Issue

It was great to see you have implemented multiple unit test cases for multiple layers like the Usecase (domain layer), ViewModel (app layer), Repository + Response classes (data layer). Now, it is a bit odd that you didn't write any unit tests for the HomeViewModel, which is the most important logic file in the application.

Also, there is no instrumented test found in the application. It would be great if a few instrumented tests to verify some basic flows in the application could be provided.

Expect

• The test coverage for this project can be improved to reach above 80% for all the ViewModel classes used.
  

• Create some instrumented tests with Expresso for verifying a simple flow (e.g. open the Survey Lists screen from the Login screen) in the application.