huntdatacenter / charm-megaraid-check Goto Github PK

Juju 2.7 has been released and should be added to ci.

The ci should have tests that upgrade from the latest version in the charm store to the one being built in ci.

The charm does not clean up/remove the NRPE checks on the Nagios server when destroying/removing the charm.

I am not sure how to implement this and have asked for advice on discourse.jujucharms.com

As a workaround, I have implemented a config flag called check-remove which can be used while the charm is still running. However this may be too late for folks that have already removed the charm. Removing and redeploying the accompanying nrpe charm on the principal application/charm should clear out the checks though.

Currently the charm just removes storcli before installing from the archive supplied by storcli-url. That is not always so graceful and possible upgrade/downgrade scenarios need to be tested more.

Need to add a deploy bundle test to ci.

I chose to fork the upstream check_lsi_raid repository https://github.com/thomas-krenn/check_lsi_raid to https://github.com/huntdatacenter/check_lsi_raid due to the long standing issue thomas-krenn/check_lsi_raid#24 which blocks the use of newer versions of StorCLI.

The default check-repo should be set to upstream again when the issue has been resolved upstream.

CI tests are failing due to a snap issue

See failure

The specific failure is:

Run sudo snap install juju --classic --channel=2.4/stable
2019-11-26T20:55:21Z INFO Waiting for restart...
error: cannot perform the following tasks:
- Run configure hook of "juju" snap if present (run hook "configure": / not root-owned 501:50)

For some reason this works in another test repository: https://github.com/szeestraten/charm-extra-nrpe-example/runs/321938679

Only related bug/issue I have found online is the following: https://forum.snapcraft.io/t/permissions-problem-using-snapcraft-in-azure-pipelines/13258/7