Giter Club home page Giter Club logo

Comments (3)

adam-fowler avatar adam-fowler commented on August 16, 2024

So should group.get("/", use: list) have a trailing slash, even though the router would treat them as the same route.

from hummingbird.

slashmo avatar slashmo commented on August 16, 2024

Good point 🤔 My reasoning for expecting /users is that if I wouldn't use a router group, I'd write router.get("/users"), not router.get("/users/"), resulting in /users and not /users/.

In the case you shared I'd probably still expect /users, but that's even more opinionated I suppose.

If we say group.get("/", use: list) shouldn't have the trailing slash it should be consistent though and all trailing slashes in routes should be stripped, except for the case of the root index route which shouldn't be empty.

from hummingbird.

adam-fowler avatar adam-fowler commented on August 16, 2024

#167 consistency is a good thing

from hummingbird.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.