Comments (3)
So should group.get("/", use: list)
have a trailing slash, even though the router would treat them as the same route.
from hummingbird.
Good point 🤔 My reasoning for expecting /users
is that if I wouldn't use a router group, I'd write router.get("/users")
, not router.get("/users/")
, resulting in /users
and not /users/
.
In the case you shared I'd probably still expect /users
, but that's even more opinionated I suppose.
If we say group.get("/", use: list)
shouldn't have the trailing slash it should be consistent though and all trailing slashes in routes should be stripped, except for the case of the root index route which shouldn't be empty.
from hummingbird.
#167 consistency is a good thing
from hummingbird.
Related Issues (20)
- Handling incoming request with stream body HOT 6
- `HBRequest.endpointPath` not set while applying middleware HOT 11
- ByteBufferAllocator is not available through HBApplication HOT 3
- Endpoint path has an inconsistent prefix
- Feature: Associate a unique ID with each request HOT 5
- Catch anything as a path component HOT 6
- Make a suggestion. HOT 5
- .env file parsing fails with #comments before an empty line
- Add macOS to swift package declaration HOT 1
- Serve static files HOT 7
- 2.x: HBFileIO without Foundation HOT 1
- 2.x: Make HBApplication a Service HOT 1
- 2.x: Split HBApplication into Builder and Running types HOT 2
- 2.x: Split context off from `HBRequest` HOT 1
- 2.x: Discussion: Use Generics to allow user to provide their own context type HOT 2
- Add async/await functions for persist
- Extract job queue manager from HBApplication HOT 1
- Swift-service-lifecycle update HOT 1
- 2.x: Conform HBDateCache to Service HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hummingbird.