Giter Club home page Giter Club logo

Comments (6)

adam-fowler avatar adam-fowler commented on May 14, 2024 1

#177 adds recursive wildcard

from hummingbird.

adam-fowler avatar adam-fowler commented on May 14, 2024
  • Yeah we don't have wildcard crossing multiple folders ** support yet. It's on the list. I'll add a separate issue to cover that.
  • Regarding accessing the parameters I think we can change it to be slightly less aggressive than a crash, maybe just return an empty parameter list. I'm not sure about the catch all as one parameter. You might as well just use the path from the uri.

from hummingbird.

adam-fowler avatar adam-fowler commented on May 14, 2024

Question does ** also mean nothing
eg

router.get("/test/**") { req in
    return req.uri.description
}

work for
GET /test/

from hummingbird.

adam-fowler avatar adam-fowler commented on May 14, 2024

I will look at a catch all, but I want to look at setting up with package-benchmarks first as router changes can have performance implications.

from hummingbird.

tib avatar tib commented on May 14, 2024

Sure, take your time, and many thanks for #177 🙏

Crashing is a bit too aggressive for sure, an empty array would be just fine. 😅

from hummingbird.

adam-fowler avatar adam-fowler commented on May 14, 2024

I think we've covered everything in #179

from hummingbird.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.