hughsie / colord-gtk Goto Github PK

The README says:

See http://colord.hughsie.com/ for more details.

but that hostname is not resolving. Perhaps it should point to this github repo instead, as I can't find any pointers to it in the 0.3.0 release downloads?

Most of the source files state:

 * Licensed under the GNU Lesser General Public License Version 2.1
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.

The exception is client/cd-convert.c, which states:

 * Licensed under the GNU General Public License Version 2
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.

The COPYING file only includes LGPL-3.0, and doesn't include the copy of the GPLv2 that cd-convert.c says should be provided.

meson.build states license : 'LGPL-2.1+' and doesn't mention the GPLv2 program.

colord-gtk.doap states <license rdf:resource="http://www.gnu.org/licenses/gpl-2.0.txt" /> but gives a description of the library that's covered by LGPL instead of GPL.

Meson is an open source build system meant to be both extremely fast, and, even more importantly, as user friendly as possible. Porting modules to Meson is a GNOME Goal.

configure.ac:115: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and its use is discouraged.
configure.ac:115: You should use the Autoconf-provided 'AC_PROG_MKDIR_P' macro instead,
configure.ac:115: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your Makefile.am files.

meson.build mentions LGPL-2.1+, but the license in this repository is for LGPL-3.0, what's the correct license for this project?

I'm having trouble getting colord-gtk's tests to work. More details of what I've tried so far are at
https://launchpad.net/bugs/1690706

The statement

See http://colord.hughsie.com/ for more details.

is false; the site is not reachable and www.hughsie.com leads to quite a different kind of service.

Hi,
I guess you migrated from gitorious , but werent the tags lost ?

I have a copy if helps , I can push them to a forked branch if it help

Regards

+ /usr/bin/make -O -j4 check
Making check in man
make[1]: Nothing to be done for 'check'.
Making check in contrib
make[1]: Nothing to be done for 'check'.
Making check in libcolord-gtk
/usr/bin/make  cd-self-test
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/colord-gtk-0.1.26/libcolord-gtk'
gcc -DHAVE_CONFIG_H -I. -I..  -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -pthread  -I/usr/include/colord-1 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include  -I.. -I../libcolord-gtk -DCD_COMPILATION -DG_LOG_DOMAIN=\"libcolord-gtk\" -DTESTDATADIR=\""../data/tests"\" -DPACKAGE_DATA_DIR=\""/usr/share"\" -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/atk-1.0   -Wall -Wcast-align -Wno-uninitialized -Wmissing-declarations -Wpointer-arith -Wcast-align -Wwrite-strings -Winit-self -Wreturn-type -Wformat-nonliteral -Wformat-security -Wmissing-include-dirs -Wmissing-format-attribute -Wclobbered -Wempty-body -Wignored-qualifiers -Wsign-compare -Wtype-limits -Wuninitialized -Waggregate-return -Wdeclaration-after-statement -Wshadow -Wno-strict-aliasing -Winline -Wmissing-parameter-type -Woverride-init -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -flto -c -o cd_self_test-cd-self-test.o `test -f 'cd-self-test.c' || echo './'`cd-self-test.c
cd-self-test.c: In function 'main':
cd-self-test.c:122:2: warning: 'g_type_init' is deprecated [-Wdeprecated-declarations]
  122 |  g_type_init ();
      |  ^~~~~~~~~~~
In file included from /usr/include/glib-2.0/gobject/gobject.h:24,
                 from /usr/include/glib-2.0/gobject/gbinding.h:29,
                 from /usr/include/glib-2.0/glib-object.h:23,
                 from /usr/include/colord-1/colord/cd-client.h:29,
                 from /usr/include/colord-1/colord.h:38,
                 from cd-self-test.c:24:
/usr/include/glib-2.0/gobject/gtype.h:688:23: note: declared here
  688 | void                  g_type_init                    (void);
      |                       ^~~~~~~~~~~
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/colord-gtk-0.1.26/libcolord-gtk'
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/colord-gtk-0.1.26/libcolord-gtk'
/bin/sh ../libtool  --tag=CC   --mode=link gcc -Wall -Wcast-align -Wno-uninitialized -Wmissing-declarations -Wpointer-arith -Wcast-align -Wwrite-strings -Winit-self -Wreturn-type -Wformat-nonliteral -Wformat-security -Wmissing-include-dirs -Wmissing-format-attribute -Wclobbered -Wempty-body -Wignored-qualifiers -Wsign-compare -Wtype-limits -Wuninitialized -Waggregate-return -Wdeclaration-after-statement -Wshadow -Wno-strict-aliasing -Winline -Wmissing-parameter-type -Woverride-init -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -flto  -Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -flto -fuse-linker-plugin -o cd-self-test cd_self_test-cd-self-test.o -lcolord -lgio-2.0 -lgobject-2.0 -lglib-2.0  -pthread -lgthread-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0  -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo-gobject -lcairo -lpixman-1 -lfontconfig -lfreetype -lpng16 -lz -lxcb-shm -lxcb -lxcb-render -lXrender -lX11 -lXext -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0  libcolord-gtk.la 
libtool: link: gcc -Wall -Wcast-align -Wno-uninitialized -Wmissing-declarations -Wpointer-arith -Wcast-align -Wwrite-strings -Winit-self -Wreturn-type -Wformat-nonliteral -Wformat-security -Wmissing-include-dirs -Wmissing-format-attribute -Wclobbered -Wempty-body -Wignored-qualifiers -Wsign-compare -Wtype-limits -Wuninitialized -Waggregate-return -Wdeclaration-after-statement -Wshadow -Wno-strict-aliasing -Winline -Wmissing-parameter-type -Woverride-init -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -flto -Wl,-z -Wl,relro -Wl,--as-needed -Wl,-z -Wl,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -flto -fuse-linker-plugin -o .libs/cd-self-test cd_self_test-cd-self-test.o -pthread  ./.libs/libcolord-gtk.so -lcolord -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo-gobject -lcairo -lpixman-1 -lfontconfig -lfreetype -lpng16 -lz -lxcb-shm -lxcb -lxcb-render -lXrender -lX11 -lXext -lgdk_pixbuf-2.0 -lgthread-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -pthread
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/colord-gtk-0.1.26/libcolord-gtk'
/usr/bin/make  check-TESTS
make[3]: Entering directory '/home/tkloczko/rpmbuild/BUILD/colord-gtk-0.1.26/libcolord-gtk'
../test-driver: line 107: 23252 Aborted                 (core dumped) "$@" > $log_file 2>&1
FAIL: cd-self-test
make[3]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/colord-gtk-0.1.26/libcolord-gtk'
make[3]: Entering directory '/home/tkloczko/rpmbuild/BUILD/colord-gtk-0.1.26/libcolord-gtk'
============================================================================
Testsuite summary for colord-gtk 0.1.26
============================================================================
# TOTAL: 1
# PASS:  0
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0
============================================================================
See libcolord-gtk/test-suite.log
Please report to http://hughsie.com
============================================================================
make[3]: *** [Makefile:1146: test-suite.log] Error 1
make[3]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/colord-gtk-0.1.26/libcolord-gtk'
make[2]: *** [Makefile:1254: check-TESTS] Error 2
make[1]: *** [Makefile:1328: check-am] Error 2
make: *** [Makefile:522: check-recursive] Error 1

On a system with two monitors attached via DisplayPort, darktable crashes whenever I keep it running while I turn the monitors off and later on again. The stacktrace looks like this:

...
#3  0x00007f23eec04344 in cd_window_device_changed_cb (device=0x4757960 [CdClient], window=0x429ccd0 [CdDevice]) at ../libcolord-gtk/cd-window.c:303
...
#8  0x00007f23ef015729 in cd_client_dbus_signal_cb (proxy=<optimized out>, sender_name=<optimized out>, signal_name=<optimized out>, parameters=0x470f380, client=0x4757960 [CdClient]) at ../lib/colord/cd-client.c:274
        object_path_tmp = 0x4851f30 "/org/freedesktop/ColorManager/devices/xrandr_Eizo_Nanao_Corporation_EV2736W_22346112_mike_1000"
        device = 0x429ccd0
        profile = 0x0
        sensor = 0x0
...

The segfaults happen in cd_window_device_changed_cb():

        /* no device set yet */
        if (window->priv->device == NULL)
                return;

because window->priv is an invalid pointer (0xaaaaaaaaaaaaaaaa) and further analysis revealed that the window in fact points to a different object than expected:

(gdb) frame 3
#3  0x00007f23eec04344 in cd_window_device_changed_cb (device=0x4757960 [CdClient], window=0x429ccd0 [CdDevice]) at ../libcolord-gtk/cd-window.c:303
303             if (window->priv->device == NULL)
(gdb) p *window
$10 = {parent = {g_type_instance = {g_class = 0x3068b00 [g_type: CdDevice]}, ref_count = 2, qdata = 0x0}, priv = 0xaaaaaaaaaaaaaaaa}
(gdb) p *device
$11 = {parent_instance = {g_type_instance = {g_class = 0x302c200 [g_type: CdClient]}, ref_count = 3, qdata = 0x4493980}}

so that window->priv is outside the CdDevice object.

These two pointers do not match what cd_window_device_changed_cb() expects but they do match what device and client are in frame 8:

(gdb) frame 8
#8  0x00007f23ef015729 in cd_client_dbus_signal_cb (proxy=<optimized out>, sender_name=<optimized out>, signal_name=<optimized out>, parameters=0x470f380, client=0x4757960 [CdClient]) at ../lib/colord/cd-client.c:274
274                     g_signal_emit (client, signals[SIGNAL_DEVICE_CHANGED], 0,
(gdb) p client
$13 = 0x4757960 [CdClient]
(gdb) p device
$14 = (CdDevice_autoptr) 0x429ccd0

AFAICS the relevant code did not change much for quite long and I'm not familiar enough with glib interfaces to be able to tell what is the problem or what the call should look like.

I'm using dist tar ball and when source code is configured with --enable-gtk-doc build fails:

Making all in doc
Making all in api
make[3]: *** No rule to make target 'colord-gtk-docs.xml', needed by 'html-build.stamp'.  Stop.
make[3]: *** Waiting for unfinished jobs....
make[3]: Entering directory '/home/tkloczko/rpmbuild/BUILD/colord-gtk-0.1.26/doc/api'
if test "/home/tkloczko/rpmbuild/BUILD/colord-gtk-0.1.26/doc/api" != "/home/tkloczko/rpmbuild/BUILD/colord-gtk-0.1.26/doc/api" ; then \
    files=`echo version.xml colord-gtk-docs.xml colord-gtk-sections.txt colord-gtk-overrides.txt  colord-gtk.types`; \
    if test "x$files" != "x" ; then \
        for file in $files ; do \
            destdir=`dirname /home/tkloczko/rpmbuild/BUILD/colord-gtk-0.1.26/doc/api/$file` ;\
            test -d "$destdir" || mkdir -p "$destdir"; \
            test -f /home/tkloczko/rpmbuild/BUILD/colord-gtk-0.1.26/doc/api/$file && \
                cp -pf /home/tkloczko/rpmbuild/BUILD/colord-gtk-0.1.26/doc/api/$file /home/tkloczko/rpmbuild/BUILD/colord-gtk-0.1.26/doc/api/$file || true; \
        done; \
    fi; \
    test -d /home/tkloczko/rpmbuild/BUILD/colord-gtk-0.1.26/doc/api/tmpl && \
        { cp -pR /home/tkloczko/rpmbuild/BUILD/colord-gtk-0.1.26/doc/api/tmpl /home/tkloczko/rpmbuild/BUILD/colord-gtk-0.1.26/doc/api/; \
        chmod -R u+w /home/tkloczko/rpmbuild/BUILD/colord-gtk-0.1.26/doc/api/tmpl; } \
fi
touch setup-build.stamp
make[3]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/colord-gtk-0.1.26/doc/api'
make[2]: *** [Makefile:426: all-recursive] Error 1
make[1]: *** [Makefile:522: all-recursive] Error 1
make: *** [Makefile:454: all] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.HxUHP6 (%build)

Will there be a new release to flush out all merged commit's. Since it has been 2 yrs since the last release.

$ rpm -q glib2 gtk3
glib2-2.61.0-3.fc31.x86_64
gtk3-3.24.8-3.fc31.x86_64

All build warnings extracted from build log:

cd-sample-window.c: In function 'cd_sample_window_class_init':
cd-sample-window.c:124:2: warning: 'g_type_class_add_private' is deprecated [-Wdeprecated-declarations]
  124 |  g_type_class_add_private (klass, sizeof (CdSampleWindowPrivate));
      |  ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/glib-2.0/gobject/gobject.h:24,
                 from /usr/include/glib-2.0/gobject/gbinding.h:29,
                 from /usr/include/glib-2.0/glib-object.h:23,
                 from cd-sample-window.c:24:
/usr/include/glib-2.0/gobject/gtype.h:1303:10: note: declared here
 1303 | void     g_type_class_add_private       (gpointer                    g_class,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~
cd-window.c: In function 'cd_window_get_profile_finish':
cd-window.c:142:2: warning: 'g_simple_async_result_propagate_error' is deprecated [-Wdeprecated-declarations]
  142 |  if (g_simple_async_result_propagate_error (simple, error))
      |  ^~
In file included from /usr/include/glib-2.0/gio/gio.h:117,
                 from cd-window.c:34:
/usr/include/glib-2.0/gio/gsimpleasyncresult.h:119:21: note: declared here
  119 | gboolean            g_simple_async_result_propagate_error  (GSimpleAsyncResult      *simple,
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cd-window.c:145:2: warning: 'g_simple_async_result_get_op_res_gpointer' is deprecated [-Wdeprecated-declarations]
  145 |  return g_object_ref (g_simple_async_result_get_op_res_gpointer (simple));
      |  ^~~~~~
In file included from /usr/include/glib-2.0/gio/gio.h:117,
                 from cd-window.c:34:
/usr/include/glib-2.0/gio/gsimpleasyncresult.h:79:21: note: declared here
   79 | gpointer            g_simple_async_result_get_op_res_gpointer (GSimpleAsyncResult      *simple);
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cd-window.c:145:2: warning: 'g_simple_async_result_get_op_res_gpointer' is deprecated [-Wdeprecated-declarations]
  145 |  return g_object_ref (g_simple_async_result_get_op_res_gpointer (simple));
      |  ^~~~~~
In file included from /usr/include/glib-2.0/gio/gio.h:117,
                 from cd-window.c:34:
/usr/include/glib-2.0/gio/gsimpleasyncresult.h:79:21: note: declared here
   79 | gpointer            g_simple_async_result_get_op_res_gpointer (GSimpleAsyncResult      *simple);
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cd-window.c: In function 'cd_window_get_profile_client_connect_cb':
cd-window.c:172:3: warning: 'g_simple_async_result_set_error' is deprecated [-Wdeprecated-declarations]
  172 |   g_simple_async_result_set_error (helper->res,
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/glib-2.0/gio/gio.h:117,
                 from cd-window.c:34:
/usr/include/glib-2.0/gio/gsimpleasyncresult.h:122:21: note: declared here
  122 | void                g_simple_async_result_set_error        (GSimpleAsyncResult      *simple,
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cd-window.c:177:3: warning: 'g_simple_async_result_complete_in_idle' is deprecated [-Wdeprecated-declarations]
  177 |   g_simple_async_result_complete_in_idle (helper->res);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/glib-2.0/gio/gio.h:117,
                 from cd-window.c:34:
/usr/include/glib-2.0/gio/gsimpleasyncresult.h:106:21: note: declared here
  106 | void                g_simple_async_result_complete_in_idle (GSimpleAsyncResult      *simple);
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cd-window.c: In function 'cd_window_get_profile_device_connect_cb':
cd-window.c:198:3: warning: 'g_simple_async_result_set_error' is deprecated [-Wdeprecated-declarations]
  198 |   g_simple_async_result_set_error (helper->res,
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/glib-2.0/gio/gio.h:117,
                 from cd-window.c:34:
/usr/include/glib-2.0/gio/gsimpleasyncresult.h:122:21: note: declared here
  122 | void                g_simple_async_result_set_error        (GSimpleAsyncResult      *simple,
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cd-window.c:203:3: warning: 'g_simple_async_result_complete_in_idle' is deprecated [-Wdeprecated-declarations]
  203 |   g_simple_async_result_complete_in_idle (helper->res);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/glib-2.0/gio/gio.h:117,
                 from cd-window.c:34:
/usr/include/glib-2.0/gio/gsimpleasyncresult.h:106:21: note: declared here
  106 | void                g_simple_async_result_complete_in_idle (GSimpleAsyncResult      *simple);
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cd-window.c:212:3: warning: 'g_simple_async_result_set_error' is deprecated [-Wdeprecated-declarations]
  212 |   g_simple_async_result_set_error (helper->res,
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/glib-2.0/gio/gio.h:117,
                 from cd-window.c:34:
/usr/include/glib-2.0/gio/gsimpleasyncresult.h:122:21: note: declared here
  122 | void                g_simple_async_result_set_error        (GSimpleAsyncResult      *simple,
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cd-window.c:217:3: warning: 'g_simple_async_result_complete_in_idle' is deprecated [-Wdeprecated-declarations]
  217 |   g_simple_async_result_complete_in_idle (helper->res);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/glib-2.0/gio/gio.h:117,
                 from cd-window.c:34:
/usr/include/glib-2.0/gio/gsimpleasyncresult.h:106:21: note: declared here
  106 | void                g_simple_async_result_complete_in_idle (GSimpleAsyncResult      *simple);
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cd-window.c: In function 'cd_window_get_profile_profile_connect_cb':
cd-window.c:239:3: warning: 'g_simple_async_result_set_error' is deprecated [-Wdeprecated-declarations]
  239 |   g_simple_async_result_set_error (helper->res,
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/glib-2.0/gio/gio.h:117,
                 from cd-window.c:34:
/usr/include/glib-2.0/gio/gsimpleasyncresult.h:122:21: note: declared here
  122 | void                g_simple_async_result_set_error        (GSimpleAsyncResult      *simple,
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cd-window.c:244:3: warning: 'g_simple_async_result_complete_in_idle' is deprecated [-Wdeprecated-declarations]
  244 |   g_simple_async_result_complete_in_idle (helper->res);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/glib-2.0/gio/gio.h:117,
                 from cd-window.c:34:
/usr/include/glib-2.0/gio/gsimpleasyncresult.h:106:21: note: declared here
  106 | void                g_simple_async_result_complete_in_idle (GSimpleAsyncResult      *simple);
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cd-window.c:253:3: warning: 'g_simple_async_result_set_error' is deprecated [-Wdeprecated-declarations]
  253 |   g_simple_async_result_set_error (helper->res,
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/glib-2.0/gio/gio.h:117,
                 from cd-window.c:34:
/usr/include/glib-2.0/gio/gsimpleasyncresult.h:122:21: note: declared here
  122 | void                g_simple_async_result_set_error        (GSimpleAsyncResult      *simple,
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cd-window.c:257:3: warning: 'g_simple_async_result_complete_in_idle' is deprecated [-Wdeprecated-declarations]
  257 |   g_simple_async_result_complete_in_idle (helper->res);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/glib-2.0/gio/gio.h:117,
                 from cd-window.c:34:
/usr/include/glib-2.0/gio/gsimpleasyncresult.h:106:21: note: declared here
  106 | void                g_simple_async_result_complete_in_idle (GSimpleAsyncResult      *simple);
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cd-window.c:263:2: warning: 'g_simple_async_result_set_op_res_gpointer' is deprecated [-Wdeprecated-declarations]
  263 |  g_simple_async_result_set_op_res_gpointer (helper->res,
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/glib-2.0/gio/gio.h:117,
                 from cd-window.c:34:
/usr/include/glib-2.0/gio/gsimpleasyncresult.h:75:21: note: declared here
   75 | void                g_simple_async_result_set_op_res_gpointer (GSimpleAsyncResult      *simple,
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cd-window.c:266:2: warning: 'g_simple_async_result_complete_in_idle' is deprecated [-Wdeprecated-declarations]
  266 |  g_simple_async_result_complete_in_idle (helper->res);
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/glib-2.0/gio/gio.h:117,
                 from cd-window.c:34:
/usr/include/glib-2.0/gio/gsimpleasyncresult.h:106:21: note: declared here
  106 | void                g_simple_async_result_complete_in_idle (GSimpleAsyncResult      *simple);
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cd-window.c: In function 'cd_window_get_profile_device_find_cb':
cd-window.c:284:3: warning: 'g_simple_async_result_set_error' is deprecated [-Wdeprecated-declarations]
  284 |   g_simple_async_result_set_error (helper->res,
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/glib-2.0/gio/gio.h:117,
                 from cd-window.c:34:
/usr/include/glib-2.0/gio/gsimpleasyncresult.h:122:21: note: declared here
  122 | void                g_simple_async_result_set_error        (GSimpleAsyncResult      *simple,
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cd-window.c:289:3: warning: 'g_simple_async_result_complete_in_idle' is deprecated [-Wdeprecated-declarations]
  289 |   g_simple_async_result_complete_in_idle (helper->res);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/glib-2.0/gio/gio.h:117,
                 from cd-window.c:34:
/usr/include/glib-2.0/gio/gsimpleasyncresult.h:106:21: note: declared here
  106 | void                g_simple_async_result_complete_in_idle (GSimpleAsyncResult      *simple);
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cd-window.c: In function 'cd_window_update_widget_plug_name':
cd-window.c:388:2: warning: 'gdk_screen_get_monitor_at_window' is deprecated: Use 'gdk_display_get_monitor_at_window' instead [-Wdeprecated-declarations]
  388 |  monitor_num = gdk_screen_get_monitor_at_window (screen,
      |  ^~~~~~~~~~~
In file included from /usr/include/gtk-3.0/gdk/gdkapplaunchcontext.h:31,
                 from /usr/include/gtk-3.0/gdk/gdk.h:32,
                 from /usr/include/gtk-3.0/gtk/gtk.h:30,
                 from cd-window.c:36:
/usr/include/gtk-3.0/gdk/gdkscreen.h:91:15: note: declared here
   91 | gint          gdk_screen_get_monitor_at_window (GdkScreen *screen,
      |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cd-window.c:390:2: warning: 'gdk_screen_get_monitor_plug_name' is deprecated: Use 'gdk_monitor_get_model' instead [-Wdeprecated-declarations]
  390 |  plug_name = gdk_screen_get_monitor_plug_name (screen, monitor_num);
      |  ^~~~~~~~~
In file included from /usr/include/gtk-3.0/gdk/gdkapplaunchcontext.h:31,
                 from /usr/include/gtk-3.0/gdk/gdk.h:32,
                 from /usr/include/gtk-3.0/gtk/gtk.h:30,
                 from cd-window.c:36:
/usr/include/gtk-3.0/gdk/gdkscreen.h:100:15: note: declared here
  100 | gchar *       gdk_screen_get_monitor_plug_name (GdkScreen *screen,
      |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cd-window.c: In function 'cd_window_get_profile':
cd-window.c:443:2: warning: 'g_simple_async_result_new' is deprecated: Use 'g_task_new' instead [-Wdeprecated-declarations]
  443 |  helper->res = g_simple_async_result_new (G_OBJECT (window),
      |  ^~~~~~
In file included from /usr/include/glib-2.0/gio/gio.h:117,
                 from cd-window.c:34:
/usr/include/glib-2.0/gio/gsimpleasyncresult.h:51:21: note: declared here
   51 | GSimpleAsyncResult *g_simple_async_result_new              (GObject                 *source_object,
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~
cd-window.c: In function 'cd_window_class_init':
cd-window.c:523:2: warning: 'g_type_class_add_private' is deprecated [-Wdeprecated-declarations]
  523 |  g_type_class_add_private (klass, sizeof (CdWindowPrivate));
      |  ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/glib-2.0/gobject/gobject.h:24,
                 from /usr/include/glib-2.0/gobject/gbinding.h:29,
                 from /usr/include/glib-2.0/glib-object.h:23,
                 from /usr/include/glib-2.0/gio/gioenums.h:28,
                 from /usr/include/glib-2.0/gio/giotypes.h:28,
                 from /usr/include/glib-2.0/gio/gio.h:26,
                 from cd-window.c:34:
/usr/include/glib-2.0/gobject/gtype.h:1303:10: note: declared here
 1303 | void     g_type_class_add_private       (gpointer                    g_class,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~
cd-sample-widget.c: In function 'cd_sample_window_enter_notify_event_cb':
cd-sample-widget.c:152:2: warning: 'gdk_cursor_new' is deprecated: Use 'gdk_cursor_new_for_display' instead [-Wdeprecated-declarations]
  152 |  cursor = gdk_cursor_new (GDK_BLANK_CURSOR);
      |  ^~~~~~
In file included from /usr/include/gtk-3.0/gdk/gdk.h:34,
                 from /usr/include/gtk-3.0/gtk/gtk.h:30,
                 from cd-sample-widget.c:24:
/usr/include/gtk-3.0/gdk/gdkcursor.h:228:12: note: declared here
  228 | GdkCursor* gdk_cursor_new   (GdkCursorType    cursor_type);
      |            ^~~~~~~~~~~~~~
cd-sample-widget.c: In function 'cd_sample_window_leave_notify_event_cb':
cd-sample-widget.c:170:2: warning: 'gdk_cursor_new' is deprecated: Use 'gdk_cursor_new_for_display' instead [-Wdeprecated-declarations]
  170 |  cursor = gdk_cursor_new (GDK_ARROW);
      |  ^~~~~~
In file included from /usr/include/gtk-3.0/gdk/gdk.h:34,
                 from /usr/include/gtk-3.0/gtk/gtk.h:30,
                 from cd-sample-widget.c:24:
/usr/include/gtk-3.0/gdk/gdkcursor.h:228:12: note: declared here
  228 | GdkCursor* gdk_cursor_new   (GdkCursorType    cursor_type);
      |            ^~~~~~~~~~~~~~
cd-sample-widget.c: In function 'cd_sample_widget_class_init':
cd-sample-widget.c:190:2: warning: 'g_type_class_add_private' is deprecated [-Wdeprecated-declarations]
  190 |  g_type_class_add_private (class, sizeof (CdSampleWidgetPrivate));
      |  ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/glib-2.0/gobject/gobject.h:24,
                 from /usr/include/glib-2.0/gobject/gbinding.h:29,
                 from /usr/include/glib-2.0/glib-object.h:23,
                 from /usr/include/glib-2.0/gio/gioenums.h:28,
                 from /usr/include/glib-2.0/gio/giotypes.h:28,
                 from /usr/include/glib-2.0/gio/gio.h:26,
                 from /usr/include/gtk-3.0/gdk/gdkapplaunchcontext.h:28,
                 from /usr/include/gtk-3.0/gdk/gdk.h:32,
                 from /usr/include/gtk-3.0/gtk/gtk.h:30,
                 from cd-sample-widget.c:24:
/usr/include/glib-2.0/gobject/gtype.h:1303:10: note: declared here
 1303 | void     g_type_class_add_private       (gpointer                    g_class,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~
cd-window.c:505: Warning: ColordGtk: incorrect number of parameters in comment block, parameter annotations will be ignored.

Building with gtk-doc option fails because of illegal character in COPYING. Presumably due to 1ea167e

Dear maintainers,

With recent changes, specifically the gtk4 support and considering that there hasn't been a release for 2 years, are there any plans to tag a new release? I understand that there might be a lot of reasons for not doing a release and distros can in principle just package latest master. In my case packaging master needs some justification, but I could not find any statement or release schedule. Would it be possible to know if there are any plans to prepare a release in the following weeks/months?

Thank you very much for your time.

+ /usr/bin/ninja test -v -j 48 -C x86_64-redhat-linux-gnu
ninja: Entering directory `x86_64-redhat-linux-gnu'
[0/1] /usr/bin/meson test --no-rebuild --print-errorlogs
1/1 colord-test-private                     FAIL     0.52 s (killed by signal 11 SIGSEGV)

Ok:                    0
Expected Fail:         0
Fail:                  1
Unexpected Pass:       0
Skipped:               0
Timeout:               0


The output from the failed tests:

1/1 colord-test-private                     FAIL     0.52 s (killed by signal 11 SIGSEGV)

--- command ---
/home/tkloczko/rpmbuild/BUILD/colord-gtk-0.2.0/x86_64-redhat-linux-gnu/libcolord-gtk/colord-gtk-test
--- stdout ---
# random seed: R02Sf5fe65c86d92186627b82e166b4ff32b
# GLib-GIO-DEBUG: _g_io_module_get_default: Found default implementation dconf (DConfSettingsBackend) for ‘gsettings-backend’
# GLib-GIO-DEBUG: _g_io_module_get_default: Found default implementation gvfs (GDaemonVfs) for ‘gio-vfs’
1..2
# Start of colord tests
-------

Full log written to /home/tkloczko/rpmbuild/BUILD/colord-gtk-0.2.0/x86_64-redhat-linux-gnu/meson-logs/testlog.txt

Recent gettext versions can extract and merge back strings from and to various file formats, not need for deprecated intltool any more. Migrating modules to gettext is a GNOME Goal.

Looks like with 0.3.0 test suite fail

+ cd colord-gtk-0.3.0
+ xvfb-run -a /usr/bin/meson test -C x86_64-redhat-linux-gnu --num-processes 48 --print-errorlogs
ninja: Entering directory `/home/tkloczko/rpmbuild/BUILD/colord-gtk-0.3.0/x86_64-redhat-linux-gnu'
ninja: no work to do.
1/2 colord-gtk4-test-private FAIL            0.18s   killed by signal 5 SIGTRAP
>>> UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MALLOC_PERTURB_=238 LD_LIBRARY_PATH=/home/tkloczko/rpmbuild/BUILD/colord-gtk-0.3.0/x86_64-redhat-linux-gnu/libcolord-gtk ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 /home/tkloczko/rpmbuild/BUILD/colord-gtk-0.3.0/x86_64-redhat-linux-gnu/libcolord-gtk/colord-gtk4-test
――――――――――――――――――――――――――――――――――――― ✀  ―――――――――――――――――――――――――――――――――――――
stdout:
TAP version 13
# random seed: R02S9bb230fcf8080320eca598e7bd08da8c
1..2
# Start of colord tests
# GLib-GIO-DEBUG: _g_io_module_get_default: Found default implementation local (GLocalVfs) for ‘gio-vfs’
stderr:

(/home/tkloczko/rpmbuild/BUILD/colord-gtk-0.3.0/x86_64-redhat-linux-gnu/libcolord-gtk/colord-gtk4-test:2905291): Gtk-WARNING **: 14:46:52.926: Unable to acquire session bus: Failed to execute child process “dbus-launch” (No such file or directory)
――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――

2/2 colord-test-private      FAIL            0.44s   killed by signal 6 SIGABRT
>>> UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 LD_LIBRARY_PATH=/home/tkloczko/rpmbuild/BUILD/colord-gtk-0.3.0/x86_64-redhat-linux-gnu/libcolord-gtk MALLOC_PERTURB_=122 ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 /home/tkloczko/rpmbuild/BUILD/colord-gtk-0.3.0/x86_64-redhat-linux-gnu/libcolord-gtk/colord-gtk-test
――――――――――――――――――――――――――――――――――――― ✀  ―――――――――――――――――――――――――――――――――――――
stdout:
TAP version 13
# random seed: R02Sccb6adeb4a0c8a23b2518de2435f4fbe
1..2
# Start of colord tests
# GLib-GIO-DEBUG: _g_io_module_get_default: Found default implementation local (GLocalVfs) for ‘gio-vfs’
# GLib-GIO-DEBUG: Using cross-namespace EXTERNAL authentication (this will deadlock if server is GDBus < 2.73.3)
not ok /colord/window - libcolord-gtk:ERROR:../libcolord-gtk/cd-self-test.c:45:cd_window_get_profile_cb: assertion failed (error == NULL): no device with that property: property match 'XRANDR_name'='screen' does not exist (cd_window_error, 0)
Bail out!
stderr:
**
libcolord-gtk:ERROR:../libcolord-gtk/cd-self-test.c:45:cd_window_get_profile_cb: assertion failed (error == NULL): no device with that property: property match 'XRANDR_name'='screen' does not exist (cd_window_error, 0)
――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――


Summary of Failures:

1/2 colord-gtk4-test-private FAIL            0.18s   killed by signal 5 SIGTRAP
2/2 colord-test-private      FAIL            0.44s   killed by signal 6 SIGABRT

Ok:                 0
Expected Fail:      0
Fail:               2
Unexpected Pass:    0
Skipped:            0
Timeout:            0

Please let me know if you need more details or want me to perform some diagnostics.