Issue/PR titles aren't outputted; instead, only the number is put in the room which isn't very helpful. We should fix this.

Subset of #9

payload for closed PR:
https://gist.github.com/patcon/11215810#file-closed-pull-request-json

{
//...
  "merged": false,
  "mergeable": true,
  "mergeable_state": "clean",
  "merged_by": null,
/...
}

payload for a merged PR:
https://gist.github.com/patcon/11215810#file-merged-pull-request-json

{
//...
  "merged": true,
  "mergeable": null,
  "mergeable_state": "unknown",
  "merged_by": {
    "login": "whit537",
    "id": 134455,
    "avatar_url": "https://avatars.githubusercontent.com/u/134455?",
    "gravatar_id": "fb054b407a6461e417ee6b6ae084da37",
//...
}

http://keepachangelog.com/en/1.0.0/

Right now, it looks like announceRepoEvent only deals with pull requests which sucks.

I would like it to accept the PageBuildEvent as well, but data.action may not equal opened so it'd just pass through. Maybe we can have something generic to show or separate methods for each event type?

Ref: http://developer.github.com/v3/activity/events/types/#pagebuildevent

They're a bit out of date

Reticketed from gratipay/roobot#21 (comment)

IRC adaptor expects rooms to start with a pound, but currently can't do that.

Hey @parkr, @strugee was asking about getting co-maintainer status on this repo:
https://twitter.com/strugee2/status/940069654667472896

I'm not actively using it anymore, so I wanted to check with you that it's ok. (It's just you and I with push access + org owners)

I'll give @parkr a week to reply, and then add you @strugee -- just wanted to make sure I'm not treading on @parkr's toes :)

I'd like to be able to respond to these events with some scripts of my own. From what I can tell, there isn't a way to add my own handler methods, is there?

Right now, there's manual configuration. Would be great to make it simpler.

Using version 1.5.0, I get this error:

hubot> [Fri Sep 18 2015 22:48:49 GMT-0400 (EDT)] INFO hubot-redis-brain: Using default redis on localhost:6379
[Fri Sep 18 2015 22:48:49 GMT-0400 (EDT)] ERROR Unable to load /Users/gableroux/repos/hubot/node_modules/hubot-github-repo-event-notifier/src/github-repo-event-notifier: SyntaxError: reserved word "function"
  at exports.throwSyntaxError (/Users/gableroux/repos/hubot/node_modules/hubot/node_modules/coffee-script/lib/coffee-script/helpers.js:197:13)
  at Lexer.exports.Lexer.Lexer.error (/Users/gableroux/repos/hubot/node_modules/hubot/node_modules/coffee-script/lib/coffee-script/lexer.js:778:14)
  at Lexer.exports.Lexer.Lexer.identifierToken (/Users/gableroux/repos/hubot/node_modules/hubot/node_modules/coffee-script/lib/coffee-script/lexer.js:102:16)
  at Lexer.exports.Lexer.Lexer.tokenize (/Users/gableroux/repos/hubot/node_modules/hubot/node_modules/coffee-script/lib/coffee-script/lexer.js:30:25)
  at exports.compile.compile (/Users/gableroux/repos/hubot/node_modules/hubot/node_modules/coffee-script/lib/coffee-script/coffee-script.js:35:36)
  at Object.loadFile (/Users/gableroux/repos/hubot/node_modules/hubot/node_modules/coffee-script/lib/coffee-script/coffee-script.js:176:14)
  at Module.load (/Users/gableroux/repos/hubot/node_modules/hubot/node_modules/coffee-script/lib/coffee-script/coffee-script.js:211:36)
  at Function.Module._load (module.js:310:12)
  at Module.require (module.js:365:17)
  at require (module.js:384:17)
  at Robot.loadFile (/Users/gableroux/repos/hubot/node_modules/hubot/src/robot.coffee:250:9, <js>:175:20)
  at /Users/gableroux/repos/hubot/node_modules/hubot-github-repo-event-notifier/index.coffee:12:11, <js>:26:33
  at FSReqWrap.cb [as oncomplete] (fs.js:226:19)

I've switched to 1.4.0 and didn't get the error.

#17 ideally shouldn't have needed to be a PR

Would be nice to do something with mustache like we do here:
https://github.com/gittip/hubot-heroku-deploy-notifier/blob/master/src/heroku-deploy-notifier.coffee

Since we have lots of diff event types, could just check an envvar derived from eventType (ie. HUBOT_GITHUB_EVENT_NOTIFIER_TEMPLATE_PULL_REQUEST)

Related: gratipay/roobot#55

There may be a mixup between 'issue' and 'issues' somewhere. GitHub webhook sends out "issues" as the event type, but I think the script may look for "issue".

Also, I'd like to add support for other types of hooks that go out, is it as simple as just doing a PR against all.coffee?

Before working through #20, I guess it makes sense to add some tests. FOR SCIENCE!

Reference: https://github.com/hubot-scripts/hubot-auth/blob/master/test/auth-test.coffee

When I use hubot-github-repo-event-notifier version 1.8 I get the following error when I start my hubot instance.

ERROR Unable to load /app/node_modules/hubot-github-repo-event-notifier/src/github-repo-event-notifier: ReferenceError: robot is not defined
at Object.<anonymous> (/app/node_modules/hubot-github-repo-event-notifier/src/github-repo-event-notifier.coffee:61:3, <js>:33:5)
at Object.<anonymous> (/app/node_modules/hubot-github-repo-event-notifier/src/github-repo-event-notifier.coffee:37:1, <js>:90:4)
at Module._compile (module.js:570:32)
at Object.loadFile (/app/node_modules/coffee-script/lib/coffee-script/coffee-script.js:182:19)
at Module.load (/app/node_modules/coffee-script/lib/coffee-script/coffee-script.js:211:36)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)
at Robot.loadFile (/app/node_modules/hubot/src/robot.coffee:355:9, <js>:224:20)
at /app/node_modules/hubot-github-repo-event-notifier/index.coffee:12:11, <js>:26:33
at FSReqWrap.cb [as oncomplete] (fs.js:258:19)

This error occurs when I am running version 1.8.0. If I switch to 1.7.0, everything works fine on startup. The dangers of using version >= 0.0.0 in my package.json I suppose.

Anyways, I am running on OSX, but have tested this both inside a docker container as well as natively with the same result.

Currently we output something like:

[https://github.com/pump-io/pump.io] Wiki page: Debugging edited by vxcamiloxv

which is annoying since you have to go find the wiki page yourself.

I would like to trigger a custom action on release event type, in order to print the body text & release name with markdown. What's the best approach for overriding eventActions = require('./event-actions/all')

Cheers!

/notify me <repo> [events]

• repo is something like parkr/my_repo, or just my_repo if you've set HUBOT_GITHUB_ORG. Let's use githubot's built-in #qualified_repo function for this
• events is optional and is a comma-separated list of events. Could also be all to specify all events.

Your hubot will require admin access to the repo in order to do this.

Current docs outdated from old script.

Just started a new hubot project, enabled the notifier and tried to simulate a Github webhook with Postman using the example payloads as specified by Github documentation (https://developer.github.com/v3/activity/events/types/#pullrequestevent).
The script skips the event with the message:

[Fri Jul 13 2018 11:45:53 GMT+0200 (Central European Summer Time)] DEBUG github-repo-event-notifier: Processing event type: "undefined"...
Ignoring undefined:closed as it's not allowed.

"dependencies": {
    "hubot": "^2.19.0",
    "hubot-diagnostics": "0.0.2",
    "hubot-help": "^0.2.2",
    "hubot-maps": "0.0.3",
    "hubot-redis-brain": "0.0.4",
    "hubot-scripts": "^2.17.2",
    "hubot-slack": "^4.5.2",
    "hubot-github-repo-event-notifier": ">= 1.8.1"
  },

I just got a notification about a PR which said "PR 1524 assigned to: strugee by strugee". It'd be more helpful if it said "PR 1524 self-assigned by strugee" instead.

Seems a little more obvious. Someone might not even know they're looking for something to do with webhooks :/

• Configuration options
• "here's the URL you put in to the webhook UI on github"
• make sure you select the right events
• json not form

Quote from https://developer.github.com/webhooks/#wildcard-event

We also support a wildcard (*) that will match all supported events. When you add the wildcard event, we’ll replace any existing events you have configured with the wildcard event and send you payloads for all supported events. You’ll also automatically get any new events we might add in the future.

Event type calculation is performed via

      if eventType in eventTypes

So setting HUBOT_GITHUB_EVENT_NOTIFIER_TYPES to *, as GitHub documentation suggests, has currently no effect.

Right now, we're checking for "action": "opened" in the payload, and then checking for a key with the enabled event types (from HUBOT_GITHUB_EVENT_NOTIFIER_TYPES).

Just realized that we could instead expect the format for the envvar to be:

HUBOT_GITHUB_EVENT_NOTIFIER_TYPES="issue:opened,pull_request:opened"

Perhaps we could default to the opened action if not specified (and down the line, perhaps have a hash specifying the default for each type).

https://www.npmjs.com/package/hubot-github-repo-event-notifier

Hey @patcon! It would be wonderful if you could release a v1.7.0. It contains #34 and would be a wonderful addition to the library. Alternatively, you could give me publishing abilities on NPM. Thanks!