Problem in native-image and HttpUtils when using virtual threads about http-kit HOT 11 CLOSED

Anyway, getting rid of ThreadLocal would be beneficial for virtual threads anyway:

Virtual threads support thread-local variables (ThreadLocal) and inheritable thread-local variables (InheritableThreadLocal), just like platform threads, so they can run existing code that uses thread locals. However, because virtual threads can be very numerous, use thread locals only after careful consideration.

https://openjdk.org/jeps/444

from http-kit.

@borkdude

Have just pushed beta2 👍
See here for the benchmarking info.

Improvements to the bench suite, and/or additional results very welcome!

from http-kit.

@borkdude Hi Michiel, thanks for pinging about this!

Before we select a solution, do you have any idea what the underlying problem might be?

from http-kit.

I suspect it's an interplay between ThreadLocal and virtual threads, but I'm not exactly sure. My hunch would be that the SimpleDataFormat class isn't as well tested as the newer java.time API with virtual threads.

(I updated the proposed Java solution)

from http-kit.

PR welcome, thanks Michiel 👍

from http-kit.

There we go: #544

from http-kit.

Thanks! Busy working on http-kit, will get it merged in the next couple days 👍

from http-kit.

Merged manually, thanks Michiel!

from http-kit.

Cool, as soon as you have a new beta, I'll bump in babashka since I want to publish some benchmarks which should be reproducible by others :)

from http-kit.

👍 Just a heads-up that the next release will also include a full benchmark suite.

from http-kit.

Cool :)

from http-kit.