Fix regression: the new default SNI client doesn't support `:insecure?` req option about http-kit HOT 2 CLOSED

Quick thought: while I'm not sure off-hand what the prior/usual semantics of an "insecure" option are meant to be, one option that could be worth considering is just reverting back to the old (pre-SNI) client when :insecure? is true.

Something like that might be a reasonable + easy stop-gap that'd help us at least restore the previous functionality without too much delay?

Again, would need to be investigated a bit. From digging through past issues, it looks like the original :insecure? feature was added here and motivated by comparison to clj-http, so we can probably check their semantics for reference.

If no one else is available to assist, I'll try take a look at this myself the next time I'm doing batched work on http-kit.

from http-kit.

This has been (at least partially) addressed in v2.8.0-beta1.

The previous tests have been reinstated, and :insecure? now gets the exact same behaviour as it did in the past.

The remaining question is if there'd be any benefit for :insecure? to instead be implemented natively by the new SNI client. Feedback welcome if anyone has any thoughts on that, otherwise I think this can be closed in the meantime since at the first least the regression should now be fixed.

from http-kit.