hsjoberg / blixt-wallet Goto Github PK

Only for on-chain.
Postpone channel restoring for now, backup system (Google Drive etc) needs to be implemented as well.

Right now it's hard-coded for checking against SubscribeInvoices, but this applies to other subscriptions.

Wix has a lib: https://github.com/wix/react-native-notifications

Consider this simple component:

import React from "react";
import { Container, Button } from "native-base";

export default ()  => {
  const [_, set] = useState(0);
  const Rerender = () => {
    console.log("RENDER");
    return (<></>);
  };

  rerender = useMemo(() => {
    return (<Rerender />);
  }, []);

  return (
    <Container>
      <Button onPress={() => set(Math.random()) } />
      {rerender}
    </Container>
  );
}

Pressing on the button so that the state changes causes Rerender component to re-render.
Replacing Container with react-natives View will solve the issue -- Rerender will not re-render if the button is pressed.

Perhaps check with up-stream?

There's currently a non-sustainable solution for showing which transactions relates channel opening.
This needs to be reworked to a solution that can track both channel openings and closings.
The gRPC doesn't give us much to go with unfortunately.

Postpone if no clear and straight forward solution is found.

There's really no need to use the SubscribeInvoice stream as we already have all information to set up a transaction in the store+database. It only confuses to use the stream.

Umbrella issue for tests

GUI testing:

• Receive
• Send
• Overview
• Settings
• On-chain
• Channels
• Welcome/Create Wallet
• LNURL

Integration and store testing:

• Index
• Lightning
• Send
• Receive
• Transaction
• Channel
• LNURL
• Google
• GoogleDriveBackup

Welcome screen(s)/On-boarding

Store a local static registry of known parties.
When paying an invoice, the pubkey of the receiver could be matched against the registry.

This is very useful for the transaction log for example Yalls, which only shows the bought article in the description.
We could prefix this the same way as the NameDesc protocol (#20).
This should be stored in its own field in the DB and NameDesc should take priority.

Umbrella issue for different setting options on the Settings window:

• Login with Pincode
• Login with Fingerprint
• Show mnemonic
• Fiat currency
• Bitcoin unit
• Show current network peers (Bitcoin)
• Set trusted node for SPV
• Name
• Show node data (Lightning)
• Automatically open channels
• Backup channels to Google drive
• Open lnd log
• About

There's no good way to keep track of who was paying an invoice.
Add a field that used in internally in the wallet to keep track for what was payed by whom.

Create a lib for handling displaying bitcoin/bits/satoshis.

Postpone/cancel if no viable sounds could be created.

To monitor the blockchain, we need to make sure the app runs every so often to sync the chain and check for channel breaches.

JobScheduler seems to be the appropriate way to handle this:
https://developer.android.com/reference/android/app/job/JobScheduler

https://medium.com/google-developers/scheduling-jobs-like-a-pro-with-jobscheduler-286ef8510129
https://developer.android.com/reference/android/app/job/JobInfo.Builder.html
https://developer.android.com/reference/android/app/job/JobScheduler
https://developer.android.com/reference/android/app/job/JobService
https://www.zoftino.com/android-job-scheduler-example

There's also PeriodicWorkRequest:
https://developer.android.com/reference/androidx/work/package-summary
https://developer.android.com/reference/androidx/work/PeriodicWorkRequest
https://developer.android.com/topic/libraries/architecture/workmanager/advanced/listenableworker

We need to figure out if MainActivity is running though (i.e the app is running)...

https://developer.android.com/reference/android/app/job/JobScheduler
https://medium.com/google-developers/scheduling-jobs-like-a-pro-with-jobscheduler-286ef8510129

Fiat unit display.
Needs backend, Blockchain.info's seems fine: https://www.blockchain.com/api/exchange_rates_api

To https://www.npmjs.com/package/react-native-qrcode-svg

https://chase-seibert.github.io/blog/2016/12/09/react-native-android-staging-variant.html
https://github.com/ismaeldcom/react-native-build-config

FlatList for the transaction list is causing unacceptable lagging for the header height navigation on Overview window.

Information on the internet suggests that this issue is only present when using the dev build of the android app and not in the actual production version.

Continuation of #3.
Save seed and pin-code inside AsyncStorage for now.

It should be possible to click on a transaction in the on-chain log to show more information about the transaction.

Google drive: https://www.npmjs.com/package/react-native-google-drive-api-wrapper
https://gist.github.com/luyx2412/2cddb9033d65403d595e069b95dad005

To provide better UX, transaction log should display the user which money was sent to.
As BOLT11 doesn't provide any way to a recipient name and node alias is not reliable or node could be hidden/unknown, it could be prefixed in the description of the BOLT11 invoice.

<name>: <description>

A name followed by a colon and two spaces could be used to clearly separate the name from the actual description. It should be easy to parse.

• Implement recipient name into description.
• Store known "identities" in sqlite and warn if two different pubkeys use the same name

TODO what to do when user does not provide a description

Keystore for storing sensitive information.

Includes:

• Seed
• Pin-code

Check how Lightning app does it

Could be postponed until after MVP depending on scope/difficulty in implementing.

Maybe start with Webview (https://github.com/react-native-community/react-native-webview) then move to GeckoView later on (a react-native component needs to be developed for this that could be its own npm-package).

BlueWallet has an in-app browser implementation here: https://github.com/BlueWallet/BlueWallet/blob/master/screen/lnd/browser.js

Store the domain where the purchase is from to be seen the transaction log.

Postpone if too complex.

Continuation of #3

Lightning App apparently uses react-native-keychain to safely store information.
https://github.com/lightninglabs/lightning-app/blob/master/src/action/keychain-mobile.js

For some reason Typescript linting is crashing on Overview.tsx, both in Atom and VSCode

Right now we need to wait for channelBalance() otherwise a flash of 0 Sat will be seen, which is not good UX.

This means we cannot improve load times further if we have to wait for channelBalance().
A simple cache of the balance would do.

This only work if the user currently has off-chain funds.
A better way would be to do a splice out/submarine swap, but it is not well established yet.

Neutrino syncs so fast that there's no real reason to always wait for syncedToChain when starting up if the user has not been a away for a while (say 7 days). The user won't have time to pay an invoice anyways so we should just let the user in to the app.

Perhaps a sync icon should be displayed in the Blixt top bar.

Arithmetic operations on milli-satoshis can lead to loss in precision.

There's a built in BigInt lib in JS nowadays that could be used.