hrishi1999 / dashboard.activity Goto Github PK

Unlike other activities, the Dashboard activity has an activity icon without a title, description and share button. A journal object is created, but the name cannot be changed within the activity.

Made a bundle using dist_xo and installed on an OLPC XO-4 running OLPC OS 13.2.10.

• "Total Files" is truncated,
• some of the pie chart legends are not visible,
• pie chart data shows activity bundle identifier tails instead of bundle names, (Distance is shown as AcousticMeasure, see activity.info),
• "User Activity" empty blocks are truncated on the right edge of display,
• when "User Activity" coloured blocks are selected, and there is more than one related journal object, the second object is truncated on the bottom edge of display,
• when the journal is changed by starting a new activity, then Dashboard is given focus using alt+tab, the list of journal entries and other data is not updated.

The Dashboard activity is having some scaling issues with Sugar.

Tested on Fedora 30 with Sugar Runner

Second Image of Dashboard activity when I switch to Sugar from Gnome

Source code was reviewed.

• "Copyright 2019 Hrishi Patel" should be "Copyright (C) 2019 Hrishi Patel", see How to apply these terms to your new programs,
• charts.py, readers.py and utils.py are GPLv3+ but the main program is GPLv2+,
• pycha is GPLv3+ but the main program is GPLv2+,
• there's no copyright on charts.py, readers.py, and utils.py, this blocks the license,
• a call to gi.require_version for Gdk is required for some operating system releases,
• in _build_heatmap the use of week numbers to determine months is not portable to other years,
• the exception handler in _render_chart covers a large body of code; it would be best to handle the exceptions in the lines that are affected, or test for the possibility they envisage,
• there are 90 flake8 warnings or errors, and no .flake8 file for the E402, see the Chat activity for how it can be configured,
• sometimes signal callbacks are named with a trailing _cb and sometimes they aren't,
• activity.info lacks a summary and some other metadata tags, README contains a useful summary,
• there is an icon for Hello World included.

Hope that helps.

Ran activity and the stop button isn't showing, when I click on a particular day in the heatmap that has a lot of entries the window isn't scrollable.

Are activity instances supposed to be shown as files?. Should that be restricted to files of a particular mime type, as the terminal activity has no mime type but shows as a file.

You've done a great job, thanks.