house9 / clerk Goto Github PK

Looks like there is threading issue in your gem. When I use it with activeadmin on login - a user being updated (with ip address, timestamp) but creator/updater are set to a wrong user. Probably the last user used by the system? And on some logins it doesn't update to any user - i.e. user not yet available in the filter chain?

Any ideas?

When someone creates a user for the first time can this set creator at the same time as the same user?

Hi, first of all thank you for the gem. Can you add a null check that if current user is blank then do not set

Hey, I like your gem but I'm getting a ton of WARNING: User#current is nil, are you including SentientController on your ApplicationController? in my test code. Now I've added a before(:suite) to make my actual test have a current_user.

  config.before(:suite) do
    @current_user = User.create(email: "[email protected]", password: "testtest", password_confirmation: "testtest")
    @current_user.make_current
  end
  config.after(:suite) do
    User.delete_all
  end

But this doesn't work with FactoryGirl linting (which runs before my actual code). So I was hoping there is a nice and easy way to turn off the warning message. From the quick read of the code I don't see it. I was hoping you could help.

I created a question on StackOverflow, and because I suspect clerk to be the reason, I post a link here.

http://stackoverflow.com/questions/43342291/specs-pass-when-run-alone-but-fail-when-full-suite-is-run

Thanks for help.