horrgs / earth Goto Github PK

Per the documentation on weather.gov, a number of values are being deprecated in the near future. Below are following snippets relevant to the values that are being deprecated.

Snippet 1:

Snippet 2:

temperature, windSpeed, and windGust will now become QuantitativeValue objects (as opposed to integers.)
temperatureUnit will be completely deprecated. QuantitativeValue objects have a property for units, and temperatureUnit will go there (in a way) under the QuantitativeValue for temperature.

Below, we have our generic request method

def req(url, method: RequestMethod, payload=None):
    headers = {
        'User-Agent': 'https://www.github.com/Horrgs/Earth',
        'Feature-Flag': 'forecast_temperature_qv'
    }
    try:
        if payload is not None:  # check if a payload is specified for HTTP request.
            req = requests.request(method=method.value, url=url, headers=headers, data=payload)  # valid payload to send with HTTP request.
        else:
            req = requests.request(method.value, headers=headers, url=url)  # no payload to send, send remaining info.
 

The issue lies with the headers. This method is to serve for multiple services, and therefore the headers for the NWS service shouldn't be sent unless it's the NWS service sending the request. Specifically, the below lines should be removed, and headers shall only send per service need.

See additional details on commit 9 here

We ran a test to see how things are working so far, here is a snippet of said response:

response = get('https://api.weather.gov/gridpoints/TOP/31,80/forecast', RequestMethod.GET)
print(response['properties'])

p = GridpointForecastGeoJson.from_json(json.dumps(response))
print(p.properties.periods)

The issue here occurs on the 3rd line with the call & loading of GridpointForecastGeoJson.
This loops back to GridpointForecast & then GridpointForecastPeriod, where the error occurs.
Specifically, this line in GridpointForecastPeriod

temperature: Dict[QuantitativeValue]

raises a TypeError with an error message of: Too few parameters for typing.Dict; actual 1, expected 2.

The error here is that Dict[] expects two arguments, see the docs here.

Thus, errors exist in the following locations:

& more.