hop-protocol / contracts Goto Github PK

Hello
I'm interested your protocol as a blockchain full stack developer.
Especially, have enough experience developed front-end with React, Web3, JavaScript/TypeScript, VueJS, NodeJS,
my discord id : RieserStern#3292
If you're interested, Plz DM me

tansferIdTreeIndex should be transferIdTreeIndex in various places.

This should be updated in v2 since changing this will give inconsistent contract bytecodes across v1 deployments.

Update
from: http://localhost:3000/whitepaper.pdf
To: https://hop.exchange/whitepaper.pdf

Add destinationChainId to TransfersCommitted and TransferSent events so that the bonder doesn't need to parse the data from calldata.

This is a very strange situation when the bridge is a tool for presence in many blockchains, and this tool has its own tokens in only one network.
And this network is L1 main - Ethereum😏

How can I start voting for the issue of HOP tokens in any L2?

As the following diagram shows :
https://github.com/hop-exchange/contracts/blob/master/assets/Hop_Contract_Inheritance_Diagram.jpg

The L1_bridge is designed as not abstract , but in the actual code it does.
So maybe your team should update the diagram due to the sync .

AFAIK , abstract contract can't be deployed .

Hi friends, I've read through the Hop protocol white paper and the contracts. Amazing work!
I've had some minor and general questions regarding the details of Hop protocol. I can not find other ways to get in touch so I just post them here. Let me know if I should post them somewhere.

1. the two links in Diagram section in readme do not seem to be the correct ones

2. don't know if it's just me, but the transferFromBridge/transferToBridge functions create a small confusion for me:

• transferFromBridge actually transfer "to" some address while transferToBridge actually transfer "from" some address

• contracts/contracts/bridges/L1_ERC20_Bridge.sol

  Lines 25 to 31 in d47c0eb

  	function _transferFromBridge(address recipient, uint256 amount) internal override {
  	l1CanonicalToken.safeTransfer(recipient, amount);
  	}
  	function _transferToBridge(address from, uint256 amount) internal override {
  	l1CanonicalToken.safeTransferFrom(from, address(this), amount);
  	}

3. swapAndSend function mentioned in readme seems to reside in L2_AmmWrapper contract instead of L2_bridge.
   Are they refering to the same contract?

4-1. I see that L2_Bridge inherit Bridge contract so it will also have bondWithdrawal function. I think it's possible that a bonder accidentally call bondWithdrawal on L2_bridge contract? (though not really a big deal)
4-2. these two functions seem to differ only in whether they have AMM swap functionality or not?

5. in Expected contract invocation section in readme

• the L2 -> L2 (bonder offline) case says:
  • ...
  • ...
  • Wait for the sending layer-2 to be confirmed on layer-1 (approximately 7 days)
  • User or Relayer calls L2_Bridge.withdraw() on the receiving layer-2

are there any more steps or wait time between these last two steps?
if I understand correctly, even if sending layer-2 is confirmed on layer-1, it doesn't mean the state on receiving layer-2 is updated immediately?

6. Can you explain more on this part in the Expected usage section in readme?
   "Credit is added to the Bonder's credit account each time transactions (from/to any chain) are successfully confirmed on layer-1. Debit is added to the Bonder's debit account each time transactions are sent (from/to any chain) but not yet confirmed on layer-1."
   6-1. what kind of transactions are to be confirmed? transfer? withdraw? bondWithdraw?
   6-2. what would be the circumstances where transactions are sent but not yet confirmed on layer-1?
   (it would be helpful to better understand what type of transactions and in what circumstances would have an affect on both credit and debt)

7. if there's transferId for each transfer, it seems it should be able to prevent multiple bonder bonding for same transfer at the same time?

8. do you have guidelines for how to become a bonder? it would be really helpful for us to better understand the protocol and assessing the risk!

Thanks alot!

diff --git a/content/fundamentals/data-products/analytics-integrations/splunk/index.md b/content/fundamentals/data-products/analytics-integrations/splunk/index.md index 704753430775a..fc2c038b1d602 100644 --- a/content/fundamentals/data-products/analytics-integrations/splunk/index.md +++ b/content/fundamentals/data-products/analytics-integrations/splunk/index.md @@ -72,11 +72,7 @@ For example: https://prd-p-0qk3h.splunkcloud.com:8088/services/collector/raw. Post Installation Notes -You can change the Index Name after initial configuration by accessing the app Set up page by clicking on the Apps dropdown and navigating to Manage Apps > Cloudflare App for Splunk > Set up. - - - -You also can find the Index Name manually by visiting Settings > Advanced search > Search macros. +You can change the Index Name after the initial configuration by clicking on the Settings dropdown and navigating to Advance search. There you can select Search macros and look for the Cloudflare App for Splunk.