hoostus / beancount-ynab Goto Github PK

This might be an edge case since my production budget is years old and has undergone several major changes, but my Budget.yfull has two masterCategories where subCategories is null:

{
	"entityType": "masterCategory",
	"expanded": true,
	"name": "New Master Category",
	"type": "OUTFLOW",
	"deleteable": true,
	"subCategories": null,
	"isTombstone": true,
	"entityVersion": "A-282",
	"entityId": "5ADFC5F6-B872-385F-3508-75CBA92A4703",
	"sortableIndex": 268435455
},
{
	"entityType": "masterCategory",
	"expanded": true,
	"name": "Income",
	"type": "INFLOW",
	"deleteable": false,
	"subCategories": null,
	"entityVersion": "H-1533",
	"entityId": "MasterCategory/__Income__",
	"sortableIndex": 1073741823
},

This causes get_categories() to fail unless a check is inserted before calling entity_dict(m['subCategories']).

See PR #4: find_devices_with_full_knowledge() is returning an empty list where A.ydevice should match. I noticed this issue with my live *.ynab4 file and build a series of tests to bear it out.

You might not always want to import everything. For instance, maybe you only want to start importing things from 2017 onwards.

in import.py, I changed line 51 to show this:

ynab = json.load(open(filename, encoding='utf-8-sig'))

Small change, but I think it's worth supporting other character sets in some way.