holmberd / virtual-scroller Goto Github PK

removeEventListener on LN275 is not using the bound handler reference at LN264.

Update to store a reference to the scroll event handler and use that to remove the handler on unmount.

Code examples are great but it would be good if there were some interactive examples to play with, e.g. scrollable list.

The component should support horizontal scrolling, e.g. for horizontal tag scroller. We should therefore add a horizontal-virtualization module similar to the vertical-virtualization module.

• Add horizontal-virtualization module (see vertical-virtualization.js).
• Add horizontal-virtualization tests.
• Add property to the VirtualScroller class to be able to select vertical or horizontal virtualization (not both).
• Change the VirtualScroller class to switch between vertical and horizontal virtualization calculations.
• Change the VirtualScroller class variable/method names to better reflect width/height, i.e. size, instead of only height.
• Add virtual-scroller tests when horizontal virtualization is enabled.

This package could benefit from adding Typescript and types.

Add class property to change between LTR and RTL (direction: rtl).

If the element's direction is rtl (right-to-left), then scrollLeft is 0 when the scrollbar is at its rightmost position (at the start of the scrolled content), and then increasingly negative as you scroll towards the end of the content.