hoglet67 / atomulator Goto Github PK

Add a full screen command line option

Possibly the leading / is being stripped off as a security measure (????)

These works on a real AtoMMC!

See comment block in the code:

Atomulator does not securely sandbox the MMC directory. For example

*CAT /.. will access the parent folder (containing the Atomulator exe file)

*DELETE /..atom.cfg will delete the atom.cfg file (!!!)

This is not a regression; it has always been the case.

The f_chdir (change directory) function does try to prevent the user moveing to a directory that is above BaseMMCPath. It does a reasonable job of this. On linux, realpath() is used, for example. This approach does not generalize to the other f_ functions, because realpath() only works if the file directory exists. So it could not, for example, be used by f_open().

Document command line options in README

I'd love to use atomulator from my front end but I can't seem to be able to launch it in fullscreen or preload a game in the tape or disk slot. These features are essential for any emulator.

Also, a way to have fullscreen without the menu bar showing would be amazing.

The AtoMMC implementation in Atomulator has some issues:

• the rom image contains v2.97E - need to update to 3.00E

• *DELETE (on Windows) gives Access Denied. Linux is fine.

• firmware lacks the following commands:

#define CMD_DIR_GETCWD		0x03
#define CMD_DIR_MKDIR		0x04
#define CMD_DIR_RMDIR		0x05
#define CMD_RENAME			0x08

• RAF test on Windows hits above issue with delete.

• RAF test on Linux hangs Atomulator at:
  

Chuckie Egg detects AtoMMC fire button continually pressed

This happens with AtoMMC PORTB joystick is disabled; when it's enabled it works fine.

This is a regression between 1.29 and 1.30, when AtoMMC was updated to the latest version:
https://github.com/hoglet67/Atomulator/compare/6d9227...26ca9?w=1

6d9227 works correctly

26ca9be has the issue

The issue is a missing else clause here:
https://github.com/hoglet67/Atomulator/compare/6d9227...26ca9?w=1#diff-f57886a1a8e27eb2c4a196d826ee9d92fc9a0dadd3bef3fdf50d0d8fdc273ad9L341

The value returned has wrongly had one added to it:

In output mode it should return the vale written (i.e. 55 and AA)

I've confirmed this on a real Atom.

At least on my UK keyboard....

and redefining doesn't seem to work for all keys.

I've tried deleting atom.cfg but that didn't help.