hoehrmann / pngwolf Goto Github PK

Could you please tag a stable version with a version number so this library can be included in homebrew?

I'm not sure if it's fault in galib or pngwolf.

Both gcc 4.9 and clang fail to compile (tested galib 2.46 and galib 2.47):

[  2%] Building CXX object CMakeFiles/pngwolf.dir/pngwolf.cxx.o
In file included from /www/pngwolf/galib/ga/GA1DArrayGenome.h:178:0,
                 from /www/pngwolf/galib/ga/ga.h:167,
                 from /www/pngwolf/pngwolf.cxx:39:
/www/pngwolf/galib/ga/GA1DArrayGenome.C: In instantiation of 'GA1DArrayAlleleGenome::GA1DArrayAlleleGenome(unsigned int, const GAAlleleSet&, GAGenome::Evaluator, void*) [with T = PngFilter; GAGenome::Evaluator = float (*)(GAGenome&)]':
/www/pngwolf/pngwolf.cxx:872:52:   required from here
/www/pngwolf/galib/ga/GA1DArrayGenome.C:225:75: error: 'initializer' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
   initializer(GA1DArrayAlleleGenome::DEFAULT_1DARRAY_ALLELE_INITIALIZER);
                                                                           ^
/www/pngwolf/galib/ga/GA1DArrayGenome.C:225:75: note: declarations in dependent base 'GAGenome' are not found by unqualified lookup
/www/pngwolf/galib/ga/GA1DArrayGenome.C:225:75: note: use 'this->initializer' instead
/www/pngwolf/galib/ga/GA1DArrayGenome.C:226:67: error: 'mutator' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
   mutator(GA1DArrayAlleleGenome::DEFAULT_1DARRAY_ALLELE_MUTATOR);
                                                                   ^
/www/pngwolf/galib/ga/GA1DArrayGenome.C:226:67: note: declarations in dependent base 'GAGenome' are not found by unqualified lookup
/www/pngwolf/galib/ga/GA1DArrayGenome.C:226:67: note: use 'this->mutator' instead
/www/pngwolf/galib/ga/GA1DArrayGenome.C:227:73: error: 'comparator' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
   comparator(GA1DArrayAlleleGenome::DEFAULT_1DARRAY_ALLELE_COMPARATOR);
                                                                         ^
/www/pngwolf/galib/ga/GA1DArrayGenome.C:227:73: note: declarations in dependent base 'GAGenome' are not found by unqualified lookup
/www/pngwolf/galib/ga/GA1DArrayGenome.C:227:73: note: use 'this->comparator' instead
/www/pngwolf/galib/ga/GA1DArrayGenome.C:228:71: error: 'crossover' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
   crossover(GA1DArrayAlleleGenome::DEFAULT_1DARRAY_ALLELE_CROSSOVER);
                                                                       ^
/www/pngwolf/galib/ga/GA1DArrayGenome.C:228:71: note: declarations in dependent base 'GAGenome' are not found by unqualified lookup
/www/pngwolf/galib/ga/GA1DArrayGenome.C:228:71: note: use 'this->crossover' instead
make[2]: *** [CMakeFiles/pngwolf.dir/pngwolf.cxx.o] Error 1
make[1]: *** [CMakeFiles/pngwolf.dir/all] Error 2

clang:

[  2%] Building CXX object CMakeFiles/pngwolf.dir/pngwolf.cxx.o
In file included from /www/pngwolf/pngwolf.cxx:39:
In file included from /www/pngwolf/galib/ga/ga.h:167:
In file included from /www/pngwolf/galib/ga/GA1DArrayGenome.h:178:
/www/pngwolf/galib/ga/GA1DArrayGenome.C:225:3: error: use of undeclared identifier 'initializer'
  initializer(GA1DArrayAlleleGenome::DEFAULT_1DARRAY_ALLELE_INITIALIZER);
  ^
/www/pngwolf/galib/ga/GA1DArrayGenome.C:226:3: error: use of undeclared identifier 'mutator'
  mutator(GA1DArrayAlleleGenome::DEFAULT_1DARRAY_ALLELE_MUTATOR);
  ^
/www/pngwolf/galib/ga/GA1DArrayGenome.C:241:3: error: use of undeclared identifier 'initializer'
  initializer(GA1DArrayAlleleGenome::DEFAULT_1DARRAY_ALLELE_INITIALIZER);
  ^
/www/pngwolf/galib/ga/GA1DArrayGenome.C:242:3: error: use of undeclared identifier 'mutator'
  mutator(GA1DArrayAlleleGenome::DEFAULT_1DARRAY_ALLELE_MUTATOR);

Good day!

I want to thank You for the project.
Tell me, are You planning to develop pngwolf in the future? Since 2012 no updates was not.

I think it will be nice to keep original filters, etc. and just let pngwolf to recompress IDAT, like advdef does.