timeoutDialog timer does not evaluate time elapsed about assets-frontend HOT 3 OPEN

Hi @nubz, one of the changes in the new implementation of the timeout dialog was to remove the expectation that setInterval will be called exactly once every 1000 milliseconds. There's a test for it here https://github.com/hmrc/assets-frontend/blob/master/assets/patterns/help-users-when-we-time-them-out-of-a-service/timeout-dialog.test.js#L525 and the implementation is here https://github.com/hmrc/assets-frontend/blob/master/assets/patterns/help-users-when-we-time-them-out-of-a-service/timeoutDialog.js#L101

Have you tested with the latest version of AF? I'd expect the upgrade to solve your problem, if not I'll gladly look deeper into it.

from assets-frontend.

In conversation with @gordonmcmullan I can see the logic of the problem. I'll take a look.

from assets-frontend.

Hi @matcarey - thanks for looking and yes when I see the tests around this all explicitly fail if a setInterval is being used... these would need quite an overhaul to implement something like this, and to be clear the problem is explicitly about relying on a forward moving timer to move forward in real time and this does not happen when the tab is not in focus. Both setTimeout and setInterval are unreliable versus real time... using setInterval at least gives us a chance to evaluate time elapsed.

from assets-frontend.