stageprompt version included in minified application js doesn't cater for newer Google analytics.js about assets-frontend HOT 5 CLOSED

Ah! This is why we were using our version which has that fix. Looks like we opted for the GOV.UK version when upgrading because the upstream of that fork has been archived.

IMO it would be better to get this added to the upstream version which has moved to GOV.UK frontend toolkit and bump our dependencies, rather than duplicate code again.

However, if this is blocking you @markhunter27 are you able to test moving back to our fork and raising an issue over on the upstream repo?

from assets-frontend.

Actually, digging a bit further into this it looks like the analytics helpers have been expanded quite a bit since we forked alphagov/stageprompt.

The best thing to do would be to try to follow the govuk-frontend-toolkit analytics guidance (which includes universal analytics) and see if we need to add anything to AF as a result.

from assets-frontend.

Cheers for the replies.
I think at the moment the most immediate solution for us is to use the local patch I mentioned above - that replicates the change that was made on the forked copy of stageprompt, and seems to do the job.

We can request a change to the GOV UK toolkit, but because we're one of several services using the 'Template as a service' approach, there's some time & impact we need to consider when stepping up the shared AF dependency version.

The later analytics docs you've shared look interesting & worth a look. But at the moment our service is using stageprompt attributes in a lot of places, so it won't be so quick to revise our approach.

from assets-frontend.

Apologies @markhunter27, I didn't spot this yesterday but there's actually already an open PR for this change in govuk_frontend_template.

I'll revert back to our fork in the interim and will keep an eye on that.

from assets-frontend.

No prob cheers. Caught up with @Fenwick17 this morning - will try to get a test of your latest AF happening in our service this afternoon.

from assets-frontend.