hmcts / service-auth-provider-java-client Goto Github PK

What would you like to change?

We had some issues regarding JWT not being re-generated when our JWT didn't contain the "exp" property in the payload.
Since this is used in conjunction with a one-time password, I believe that in the case of the JWT not containing the "exp" property, we should always re-generate it (i.e. re-generating should be the default behaviour).
My fear is that if we ever handle a payload that doesn't have an "exp" property, we'll be always returning the same token until spring is restarted.

I'd like to know what the team thinks about it. This is only my interpretation.

References:
One-time password:

Re-generation logic:

How do you think that would improve the project?

I think it could prevent problems in production and make functional testing less dependant on testers using the "exp" property.

If this entry is related to a bug, please provide the steps to reproduce it

1. Mock the return of the "/lease" endpoint to be a valid JWT with no "exp" property.
2. Generate the token (AuthTokenGenerator.generate())
3. Reset the mock
4. Mock it again with another valid JWT token also with no "exp" property.
5. Generate the token (AuthTokenGenerator.generate())
   You will see that steps 2 and 5 will generate the same token (i.e. the service no longer queries the "/lease" endpoint.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update dependency au.com.dius.pact.consumer:junit5 to v4.6.10
• Update plugin au.com.dius.pact to v4.6.10
• Update dependency pmd to v7
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

github-actions

.github/workflows/changelog.yml

• release-drafter/release-drafter v6

.github/workflows/gradle.yml

• actions/checkout v4
• actions/setup-java v4

.github/workflows/jitpack_build.yml

• actions/checkout v4

gradle

settings.gradle

build.gradle

• io.spring.dependency-management 1.1.5
• org.springframework.boot 3.3.1
• org.owasp.dependencycheck 9.2.0
• com.github.ben-manes.versions 0.51.0
• se.patrikerdes.use-latest-versions 0.2.18
• au.com.dius.pact 4.1.11
• checkstyle 10.17.0
• pmd 6.55.0
• org.springframework.cloud:spring-cloud-starter-openfeign 4.1.2
• io.github.openfeign:feign-jackson 13.3
• com.warrenstrange:googleauth 1.5.0
• com.auth0:java-jwt 4.4.0
• jakarta.servlet:jakarta.servlet-api 6.1.0
• junit:junit 4.13.2
• org.assertj:assertj-core 3.26.0
• org.mockito:mockito-core 5.12.0
• org.springframework.cloud:spring-cloud-contract-wiremock 4.1.3
• au.com.dius.pact.consumer:junit5 4.1.11
• au.com.dius.pact.consumer:junit5 4.1.11
• org.junit.jupiter:junit-jupiter-api 5.10.2
• org.junit.jupiter:junit-jupiter-engine 5.10.2
• org.junit.jupiter:junit-jupiter-api 5.10.2

gradle-wrapper

gradle/wrapper/gradle-wrapper.properties

• gradle 8.8

---

• Check this box to trigger a request for Renovate to run again on this repository