hlindberg / puppet Goto Github PK

The checks if something is adaptable or not are quite meaningless and only steals performance. No logic so far has the need to block adaptions.

Parameter with default should come after parameters without

Close this as the last issue as this closes the milestone.

Interpolation in lexer turns source into VARIABLE at start of interpolation expression at all times (if it is a valid variable name). This inhibits calling a function as the first thing in interpolation. It should do this differently.

Either a new token VAR_OR_NAME, or just a NAME, and let the evaluation handle the "it is a variable" evaluation.

The parser error calls should in general build an error element instead of just bailing out. This to enable output of multiple errors/warnings.

e.g.

$a = $b = 1

Puppet logs and handles deprecations differently than other logged events.

Make it possible to mark an Issue as being "deprecation", and then issue the warning a different way (using Puppet.deprecation_warning).

A language compliance level setting should control the set of issues to validate (the error_checks, etc. individual settings can be used to override the basic configuration for
the given language compliance level).

A level of "current" means the "released" (just like for the parser setting), and "future" means "all extra options".

The validator now uses a check if the parameter name is all digits, not if it is numeric. This validation should check for being numeric the same way as scope detects if a variable is numeric and picks up a value from an ephemeral scope.

Validate things like:

  1
  1+ 2
  $a

Are validated if they are anywhere but last in a block. This is somewhat difficult when functions are called as part of an expression, and it is not known if they have side effects or not (one clue is if functions are rvalue producing or not).

There should be a deprecation warning, or an error.

Close this as the last issue for 3.x - with lang ver compliance milestone as this closes the milestone.

Add a setting for issues that should produce errors, warnings or be ignored.

Implement at settings using

• error_checks
• warning_checks
• ignore_checks

Each taking a comma separated list of Issue names.

Since a RHS of string in matches is unfinished in AST evaluation impl (it uses the string as is), validation should flag this as not compliant with the 3.1 AST.

This to prevent
1 + 1
2 + 2
etc.

Remember that r-value functions may have side effects.

Parse error with unclosed quote outputs some bizarre mumbo jumbo involving
newlines and stuff

Unclosed quote after '' in '
' on node...

Chained assignments should evaluate correctly.

$a = $b = 1
$a = 1 + ($b = 1)
$a = $b += [10]