hleveillegauvin / sib2humplugin Goto Github PK

At the moment, slurs are assumed to start and end in the same staff/voice.

This is not always the case, especially for piano music. For example:

will not generate a slur, because there is no 1st note voice where the slur begins, and thus the slur is never recorded

The code that evaluates the need for spine path indicators works at the bar level, not at the note level. For this reason, deleted rests will yield an illegal Humdrum file. For example, this:

... yields the following humdrum file :

A good workaround for now is to run the Replace Deleted Rests before running the sib2hum plugin.

Whole-Measure Rests are currently indicated using the generic "rr" signifier token. However, Humdrum Verovio Viewer doesn't support this, only the more elegant x%yr version (see https://doc.verovio.humdrum.org/humdrum/getting_started/#rests). Using the **recip notation would increase compatibility with Verovio and would help QA.

A workaround for now is to run the Split Bar Rests plugin before running Sib2hum.

Currently, going from, say 6 to 4 spines looks something like this ...

... but this is illegal. Instead, it should be done using multiple lines, like this ...

Right now this:

yields this in VHV:

I believe that iterating from smallest voice number to largest voice number (as opposed to the opposite) will solve this issue. Need to change code accordingly.