hkust-octad-lab / airtrafficsim Goto Github PK

Implement additional weather data sources including METAR data and historic radar image data.

Suggestions and ideas are welcomed.

To complete the final function in the route detection module - airways detection such that AirTrafficSim can convert and generate full flight simulation from historic data.

I installed locally and was able to see the UI and use it in replay mode. But when I click on the "Simulate" button in the bottom of the screen and select a scenario, it loads forever and does not show anything. Note that when I click replay and then select "Simulation" from the box that opens, I can run those scenarios.

This should be fixed or fail more gracefully if there is a reason (e.g. missing data files)

Part of JOSS review here

The docstrings format is somewhat inconsistent across the code. It would be good to stick to one format.

Also, some functions lack a doctring or have one which does not give much information. This could be improved to help contributions and future maintenance.

Part of JOSS review here

Right now, VNAV and top of descent are not implemented. It is important to add these functions to enable AirTrafficSim to achieve full-flight simulation. Feel free to propose methodologies here!

The following sentence was unclear to me while reading the article/paper submitted to JOSS:
"It can also control the aircraft based on the target state inputted by the user and algorithm to simulate ATC command". Could you elaborate on this in the paper or in the documentation?

Part of JOSS review here

The instructions and documentation tell the user to download and unzip the Bada 3.15 files.

In the EuroControl site there are over 160 files associated with my Bada 3 license. It is unclear which file(s) need to be downloaded and unzipped.

I believe the base file is: Release Files | 3.15 | 24 June 2019 | 1.39 MB

But then there are monthly files for every month since June 2019. Do all of those need to be downloaded and installed as well?

It would be good to add a contribution guide document at the top level of the repo, to summarise what process the users should follow when proposing changes, adding issues, code etc. Example here.

Part of JOSS review here

The map sometimes fails to fully render when I run replays. This also happens sometimes when I zoom in and out and when I switch satellite image on and off. Is there a way to make this smoother/more reliable?

See picture below for an example

Part of JOSS review here

Add a simulation variable delta_t to enable adjustable timestep in simulation. Right now, each timestep is defaulting to 1 second.

The codebase currently does not have any unit or integration tests. These should be added, at least for the most important methods. A continuous integration pipeline for testing could also be considered.

Part of JOSS review here

The installation instructions should go through the steps needed to add BADA data or some alternative. At the moment this is only discussed in the docs. As mentioned by the other reviewer I was able to run with BADA data because I have a license but other users might be confused and not be able to run the software.

Part of JOSS review here

If I modify DemoEnv.py as follows:

self.aircraft_head = Aircraft(self.traffic, call_sign="GHOST", aircraft_type="C25C", flight_phase=FlightPhase.CRUISE, configuration=Config.CLEAN, lat=43.223267, long=71.631273, alt=5000.0, heading=175.0, cas=250.0, fuel_weight=10000.0, payload_weight=12000.0)

Then the simulation runs as expected.

If I try to place the aircraft at Concord, NH, USA using the following code:

self.aircraft_head = Aircraft(self.traffic, call_sign="GHOST", aircraft_type="C25C", flight_phase=FlightPhase.CRUISE, configuration=Config.CLEAN, lat=43.223267, long=-71.631273, alt=5000.0, heading=175.0, cas=250.0, fuel_weight=10000.0, payload_weight=12000.0)

Then the simulation fails with the following:

emitting event "loadingMsg" to all [/] ERA5 data exists. Traffic.py - add_aircraft() GHOST Type: C25C Traffic.py - add_aircraft() FOLLOW Type: A20N emitting event "simulationEnvironment" to all [/] Exception in thread Thread-7 (_handle_event_internal): Traceback (most recent call last): File "/opt/homebrew/Caskroom/miniforge/base/envs/airtrafficsim/lib/python3.11/threading.py", line 1038, in _bootstrap_inner self.run() File "/opt/homebrew/Caskroom/miniforge/base/envs/airtrafficsim/lib/python3.11/threading.py", line 975, in run self._target(*self._args, **self._kwargs) File "/opt/homebrew/Caskroom/miniforge/base/envs/airtrafficsim/lib/python3.11/site-packages/socketio/server.py", line 733, in _handle_event_internal r = server._trigger_event(data[0], namespace, sid, *data[1:]) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/homebrew/Caskroom/miniforge/base/envs/airtrafficsim/lib/python3.11/site-packages/socketio/server.py", line 758, in _trigger_event return self.handlers[namespace][event](*args) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/homebrew/Caskroom/miniforge/base/envs/airtrafficsim/lib/python3.11/site-packages/flask_socketio/__init__.py", line 282, in _handler return self._handle_event(handler, message, namespace, sid, ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/homebrew/Caskroom/miniforge/base/envs/airtrafficsim/lib/python3.11/site-packages/flask_socketio/__init__.py", line 828, in _handle_event ret = handler(*args) ^^^^^^^^^^^^^^ File "/opt/homebrew/Caskroom/miniforge/base/envs/airtrafficsim/lib/python3.11/site-packages/airtrafficsim/server/server.py", line 153, in run_simulation env.run(socketio) File "/opt/homebrew/Caskroom/miniforge/base/envs/airtrafficsim/lib/python3.11/site-packages/airtrafficsim/core/environment.py", line 134, in run self.step(socketio) File "/opt/homebrew/Caskroom/miniforge/base/envs/airtrafficsim/lib/python3.11/site-packages/airtrafficsim/core/environment.py", line 81, in step self.traffic.update(self.global_time) File "/opt/homebrew/Caskroom/miniforge/base/envs/airtrafficsim/lib/python3.11/site-packages/airtrafficsim/core/traffic.py", line 262, in update self.weather.update(self.lat, self.long, self.alt, File "/opt/homebrew/Caskroom/miniforge/base/envs/airtrafficsim/lib/python3.11/site-packages/airtrafficsim/core/weather/weather.py", line 124, in update ds = self.weather_data.sel(longitude=xr.DataArray(long, dims="points"), latitude=xr.DataArray(lat, dims="points"), time=np.datetime64( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/homebrew/Caskroom/miniforge/base/envs/airtrafficsim/lib/python3.11/site-packages/xarray/core/dataset.py", line 2642, in sel query_results = map_index_queries( ^^^^^^^^^^^^^^^^^^ File "/opt/homebrew/Caskroom/miniforge/base/envs/airtrafficsim/lib/python3.11/site-packages/xarray/core/indexing.py", line 190, in map_index_queries results.append(index.sel(labels, **options)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/homebrew/Caskroom/miniforge/base/envs/airtrafficsim/lib/python3.11/site-packages/xarray/core/indexes.py", line 498, in sel raise KeyError(f"not all values found in index {coord_name!r}") KeyError: "not all values found in index 'longitude'"

The only difference between the two is the negative sign on the longitude.

Implement more performance models, especially the open-source OpenAP model. Suggestions and contributions are welcomed for adding new performance models, including drones and UAM models.

To update the client-side code for better code packaging and UI/UX.

Code update

• Remove Resium dependencies
• Update Cesium.js to newest version
• Improve code structure with React.FC

UI update

• Update setting box
• Improve imagery layer selection
• Improve default Mapbox map loading time

Suggestions are welcomed!