hitanshu-dhawan / popcorn Goto Github PK

• low res images for RecyclerView

• high res images for DetailActivity

when getting data from TMDb there are values which are not defined and are null.
Handle all such nulls, and ensure a proper check on these properties before using them.

also when user fav, un_fav any movie it should immediately reflect the fav movies fragment.

when a fragment is removed from activity and the retrofit call completes there is a runtime error there...
cancel the retrofit calls on onDestroyView() of the fragment.

• don't fetch each movie individually from API. It will give 429 error.

• store id, poster_path, title(name) in DB and use that info to show movies. This will save API calls.

https://gist.github.com/udacityandroid/ee8fe10c04ec2d912c509ee3fb287149

images are not showing in the description activity..poster and the backdrop image of the movie content...

it will also solve #3 error.

don't add setOnClickListener() inside onBindViewHolder()
https://stackoverflow.com/questions/33845846/why-is-adding-an-onclicklistener-inside-onbindviewholder-of-a-recyclerview-adapt

https://developer.android.com/training/tv/playback/onboarding.html

bro i think user should have the option to remove the favourite movie from the list from the main page by tap on it but i didnt found it ...To remove we have to do it in the detailactivity..and while removing the list is not updated at the same time