Giter Club home page Giter Club logo

staticwoman's People

Contributors

alexwaibel avatar andgineer avatar badele avatar binarymist avatar chmac avatar curioswati avatar deadlydog avatar doocey avatar eduardoboucas avatar ericbusch avatar firasuke avatar hispanic avatar jovil avatar justinkelly avatar lasocial avatar maciek134 avatar ntsim avatar purpleidea avatar silentcomics avatar simonv3 avatar sukiletxe avatar sukima avatar tbodt avatar vincenttam avatar wd15 avatar wes-brooks avatar willymcallister avatar yifanlu avatar zburgermeiszter avatar zongren avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

staticwoman's Issues

Notification email not sent to subscribers when consent model set to none

Hi, Michael
first of all, thank you for all the additional work you did on Staticman here. I'm just right now trying to get it to work. I have already working instance of original Staticman on my heroku and was initially set to do some work on my fork but i stumbled upon your fork-revision : Staticwoman. It seems to just have all i need. I did deployed your fork on heroku as well.

Did every configuration required but i'm stuck on last piece of everything : Mailgun sending notification email to subscribers. It does NOT send it all and i have no idea what is happening withing the instance as there is now visible errors on heroku logs.

It's weird even more because i'm using IDENTICAL configuration of my mailgun domain on your instance. I can see Staticwoman creating mailing list actually, but emails are not sent. I have consent model set to "none" - every required variables copied verbatim from previous Staticman instance to this one and i have them as heroku Config Vars.
(but i also tried with config.production.json with domain and apikey properly encrypted....)

Do you have any idea how can i debug this issue ? because everything else seems to work A-OK (including adding subscribers to mailing list as i mentioned -> so it seems that Staticwoman is properly communicating with Mailgun API)

I would love to get into the problem myself and not waste your time but i don't see any way how i can debug this line by line what is happening -> i see console.logs here and there, like in SubscriptionsManager but they are not showing on heroku

p.s. should i use Mailgun Private API KEY with this fork or maybe something changed i need to use Mailgun's "Sending API keys" (defined explicitly for certain domain)

p.s. 2
Using Mailgun API via curl seems to work as well (using same API key same mailgun host and domain)

Any help or advise would be great

Originally posted by @radekkozak in PR #12 (comment)

Suggestion: make subscribeConfirmLink a config rather than a form data

For the case of double opt-in for notifications, the subscribeConfirmUrl must be provided as a field of options in the form. However, I think this link is not related to a specific comment. As such, I'm not sure it belongs in the form.

It would appear more logical to me to make it part of the site config (I know where my server is) or the server config (I know where I, the server, am).

Or is it for GDPR purpose, in order to save this information along with the rest?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.