Giter Club home page Giter Club logo

christopher-morley_parnassus-on-wheels's Introduction

Hi there, I'm Isaac Halvorson 👋

Thanks for checking out my GitHub profile. It's good to have you here.

About Me

I'm a macOS, iOS, and web developer living in Minneapolis, MN. In my free time, I blog at my homepage hisaac.net, listen to as much music as possible, tinker with code, and spend time with my wife and kids.

My interests include cars, science fiction, music, technology, and open source software. Ask me my thoughts on Benjamin Sisko, Londo Mollari, Aphex Twin, or Neil Young sometime. I've got many thoughts to share.

I currently work as a Senior Mobile Infrastructure Engineer at Tandem Diabetes Care, a manufacturer of insulin pumps for diabetics.

You can find my résumé here: hisaac.net/resume

Elsewhere

Here are all the places you can find me elsewhere:

christopher-morley_parnassus-on-wheels's People

Contributors

hisaac avatar

Watchers

 avatar  avatar  avatar

christopher-morley_parnassus-on-wheels's Issues

content.opf issues

  • Remove cc: namespace from the <package> element. (This was probably removed in the template after you had already started production.)
  • http://standardebooks.org namespace must be https across entire project. This can be a simple project-wide find and replace.
  • long-description must be escaped HTML. I see the book title is not italicized in there either. See the metadata manual: https://standardebooks.org/contribute/metadata

titlepage.svg issues

  • titlepage viewbox must be sized to exactly fit the text plus the required padding. You can copy and paste the viewbox from a different titlepage with a two-line title and one-line author, like Agatha Christie's Mysterious Affair at Styles.
  • I see titlepage.svg has some kind of aria-label which should not be there. Make sure to remove that and run build-images again.

toc.xhtml issues

  • Chapter numbers should not be in their own <span> element. You can pull the roman semantic into the parent <a> element and remove the <span>. See any other ToC for an example.

Semantics

  • I see you have a hymn in there. Instead of using a class, this should be targeted with z3998 semantics. z3998 has both the "song" and "hymn" keyword, you can use either one as appropriate. Then, remove the class and target using the epub:type attribute.
  • The hymn header should be in a <header> element. Remove the class and target it with specific CSS, for example: [epub|type~="z3998:hymn"] header p.
  • You can remove the governers-calling-card-location class, I don't know why that's styled with a 1em text indent. In that same block, "Raleigh Stone Stafford" is not a signature, it's just the guy's name. So you can target that with a more clever selector like .governers-calling-card p:first-child and drop the class entirely.
    -The calling-card-signoff class seems to be unused, please remove it.
  • Remove the p[epub|type~="z3998:song"] span:nth-child(even) selector; this is not only too complex for most ereaders but it's not in our standard. Instead use the "i1" class and selector to indent each specific line, per our standard.
  • I see there's a journal excerpt styled in all italics. I would prefer to remove the italics here, since the margin on the <blockquote> element is enough visual signal to the reader to indicate that we're reading a quotation. So you can remove that class and the associated styling.
  • Remove <hr/> from the newspaper-clipping section. The semantics of <hr/> are "scene break" and it should not be used if all you want is a dividing line for visual presentation. Instead you can style it something like this: .newspaper-clipping p + p{ border-top-width: 1px }. (Note that we don't assign a color, so that reading systems can pick a color for night mode.)
  • In chapter-12.xhtml, <li> items must have a direct block-level descendent like <p>, per our semantics manual. Make sure to do that for any other <li> elements there might be in the book.
  • In chapter-1.xhtml the book-title class should be in a <blockquote> element, and make sure to indent the line following a <br/> to the same indentation level.
  • In letters, the first line following a salutation should not be indented. You can add a style to catch all those.
  • In chapter-1.xhtml, in the first letter, <p>Believe us, ... should be in the <footer> element. <p>Believe us, is the valediction, not the <footer> is not the valediction. A valediction is the line like "Sincerely," which is usually followed by a signature. Double check any other letters in the book to make sure to catch issues like these.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.