hidjou / classsed-react-firebase-functions Goto Github PK

Error while verifying token  TypeError: Cannot read property 'data' of undefined
    at FBAuth.admin.auth.verifyIdToken.then.then (/srv/index.js:71:46)
    at <anonymous>
    at process._tickDomainCallback (internal/process/next_tick.js:229:7) 

const FBAuth = (req, res, next) => {
    let idToken;
    if (
      req.headers.authorization &&
      req.headers.authorization.startsWith('Bearer ')
    ) {
      idToken = req.headers.authorization.split('Bearer ')[1];
    } else {
      console.error('No token found');
      return res.status(403).json({ error: 'Unauthorized' });
    }
  
    admin.auth().verifyIdToken(idToken)
        .then((decodedToken) => {
            req.user = decodedToken;
            return db
              .collection('users')
              .where('userId', '==', req.user.uid)
              .limit(1)
              .get();
          }).then((data) => {
            req.user.username = data.docs[0].data().username;
            return next();
          }).catch((err) => {
            console.error('Error while verifying token ', err);
            return res.status(403).json(err);
          });
};

  return db
    .collection('comments')
    .orderBy('createdAt', 'desc')
    .where('screamId', '==', req.params.screamId)
    .get();
})
.then((data) => {
  screamData.comments = [];
  data.forEach((doc) => {
    screamData.comments.push(doc.data());
  });
 return res.json(screamData);
})
.catch((err) => {
  console.error(err);
  res.status(500).json({ error: err.code });
});

>  TypeError: Cannot read property 'trim' of undefined
>      at isEmpty (/Users/***/***/***/***/functions/index.js:69:14)
>      at /Users/***/***/***/***/functions/index.js:93:7

const isEmpty = (string) => {
  if (string.trim() === '') return true;
  else return false;
};

Error: Value for argument "data" is not a valid Firestore document. Cannot use "undefined" as a Firestore value (found in field userId).
at Object.validateUserInput (C:\Users\alanro\Projects\PlayPlay2\functions\node_modules\@google-cloud\firestore\build\src\serializer.js:277:15)
at validateDocumentData (C:\Users\alanro\Projects\PlayPlay2\functions\node_modules\@google-cloud\firestore\build\src\write-batch.js:612:26)
at WriteBatch.set (C:\Users\alanro\Projects\PlayPlay2\functions\node_modules\@google-cloud\firestore\build\src\write-batch.js:232:9)
at DocumentReference.set (C:\Users\alanro\Projects\PlayPlay2\functions\node_modules\@google-cloud\firestore\build\src\reference.js:330:14)
at db.doc.get.then.then.then (C:\Users\alanro\Projects\PlayPlay2\functions\index.js:131:48)
at process._tickCallback (internal/process/next_tick.js:68:7)

const functions = require('firebase-functions');
const admin = require('firebase-admin');
const firebase = require('firebase');
const app = require('express')();

admin.initializeApp();

const firebaseConfig = {
   ...
};

firebase.initializeApp(firebaseConfig);

const db = admin.firestore();

const isEmpty = (string) => {
	if (string.trim() == '') {
		return true;
	} else {
		return false;
	}
}

const isEmail = (email) => {
	const regEx = /^(([^<>()\[\]\\.,;:\s@"]+(\.[^<>()\[\]\\.,;:\s@"]+)*)|(".+"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/;
	if (email.match(regEx)) {
		return true;
	} else {
		return false;
	}
}

// SIGNUP ROUTE
app.post('/signup', (req, res) => {
	const newUser = {
		email: req.body.email,
		username: req.body.username,
		password: req.body.password,
		confirmPassword: req.body.confirmPassword
	}

	let errors = {};

	// check if email is not empty and is valid
	if (isEmpty(newUser.email)) {	errors.email = 'Email field must not be empty'} 
	else if (!isEmail(newUser.email)) {	errors.email = 'Email must be valid' } 

	// check if other fields are empty
	if (isEmpty(newUser.password)) { errors.password = 'Password must not be empty' }
	if (newUser.password !== newUser.confirmPassword) { errors.confirmPassword = 'Passwords must match' }
	if (isEmpty(newUser.username)) { errors.username = 'Username must not be empty'}

	if (Object.keys(errors).length > 0) {
		return res.status(400).json(errors)
	}

	let token, userId;
	// TODO: validate data
	db.doc(`/users/${newUser.username}`).get()
		.then(doc => {
			console.log(newUser)

			if (doc.exists) {
				return res.status(400).json({ username: 'this username is already taken'})
			} else {
				return firebase
					.auth()
					.createUserWithEmailAndPassword(newUser.email, newUser.password)
			}
		})
		.then((data) => {
			console.log('data:', data)
			userId = data.user.userId
			console.log('userId:', userId)
			return data.user.getIdToken();
		})
		.then((idToken) => {
			token = idToken;
			const userCredentials = {
				username: newUser.username,
				email: newUser.email,
				createdAt: new Date().toISOString(),
				userId
			}
			return db.doc(`/users/${newUser.username}`).set(userCredentials)
		})
		.then(() => {
			return res.status(201).json({ token });
		})
		.catch((err) => {
			console.error(err);
			if(err.code === 'auth/email-already-in-use') {
				return res.status(400).json({ email: 'email is already in use'})
			} else {
				return res.status(500).json({ error: err.code });
			}
		})
})

exports.api = functions.https.onRequest(app);

exports.getScream = (req, res) => {
  let screamData = {};
  db.doc(`/screams/${req.params.screamId}`)
    .get()
    .then((doc) => {
      if (!doc.exists) {
        return res.status(404).json({ error: 'Scream not found' });
      }
      screamData = doc.data();
      screamData.screamId = doc.id;
      return db
        .collection('comments')
        .orderBy('createdAt', 'desc')
        .where('screamId', '==', req.params.screamId) //if i remove this, the functionality works
        .get();
    })
    .then((data) => {
      screamData.comments = [];
      data.forEach((doc) => {
        screamData.comments.push(doc.data());
      });
      return res.json(screamData);
    })

    .catch((err) => {
      console.error(err);
      res.status(500).json({ error: err.code });
    });

=== Serving from '/Users/vincenttern/reactApps/socialapp-functions'...

⚠  Your requested "node" version "8" doesn't match your global version "10"

Error: An unexpected error has occurred.

{
   "body": "New scream",
   "userHandle": "new"
}