Giter Club home page Giter Club logo

Comments (10)

bjrne avatar bjrne commented on July 29, 2024 2

Thanks! You were correct indeed. I am using ubuntu 20.04 LTS with python3.8 and originally pip 20.0.2, which was upgraded to 22.3.1 (newest) and works now. Weirdly enough, I don't remember pip ever notifying me of a new version. Feel free to close this, thanks for your time and effort!

I am thinking about supporting this library a bit more, is there some coordination going on between the contributors somewhere? I see some open issues with varying degrees of completeness. There is technical debt as well as discussions about (testing) the quality of scraper outputs (#162). Is there some ranked list with priorities or people to talk to?

from recipe-scrapers.

bjrne avatar bjrne commented on July 29, 2024 2

Thanks for keeping me up to date, I have been sick for some time now and will get back to you soon :) But I do have experience with git and parallel feature development.

from recipe-scrapers.

hhursev avatar hhursev commented on July 29, 2024

Hey, thanks for taking the time to notify us!

Can you provide us with more information?

  • what OS you are on
  • python and pip versions (after you activate the venv)

I suspect your pip version is dated. Will go out on a limb if I were you and upgrade it python -m pip install --upgrade pip. I think you won't be facing problems doing so 🤞 .

Please let us know if pip being older version was indeed the problem so we can update the README accordingly.

from recipe-scrapers.

hhursev avatar hhursev commented on July 29, 2024

Glad to hear you are willing to contribute to the lib!

I don't think we have a clear coordination who does what or clear priority of the tasks/issues one can per take.

@jayaddison may have a better idea what would be a good first issue(s) for you tackle on.

I'll think over this weekend how we can coordinate better going forwards.

from recipe-scrapers.

jayaddison avatar jayaddison commented on July 29, 2024

Hi @bjrne! Welcome. We don't really have any chat/forum co-ordination for this library, nor task priorities - communication is through GitHub issues and pull requests, and although I can't speak for other contributors, I mostly work on things when I feel there's some need to do that (emergent priority, rather than planned, I suppose).

I probably broke the README while trying to make it easier for new developers to onboard, argh - see #617 for a long and ongoing conversation about some of the options and what has happened so far.

from recipe-scrapers.

jayaddison avatar jayaddison commented on July 29, 2024

@bjrne do you have any experience with managing software projects that have multiple version branches, out of interest?

(the reason I ask: I started a v15 branch a little while ago, but am slightly worried it may go out-of-sync or become difficult to keep up-to-date with main)

Any time taking a look at that and providing feedback would be useful (for me at least; hopefully for the library too!)

from recipe-scrapers.

jayaddison avatar jayaddison commented on July 29, 2024

And to explain the reasoning behind having a v15 branch in the first place: as mentioned in #617, we'd like to remove the requests dependency from the library at some point - but doing that will break the existing scrape_me interface, so it's probably best to put that in a major version update.

from recipe-scrapers.

jayaddison avatar jayaddison commented on July 29, 2024

@bjrne actually, one more (hopefully easier and perhaps more rewarding) idea: running pylint on this codebase and finding improvements to apply could be worthwhile.

My guess is that it might report a lot of things to begin with - that's ok, we can start gradually and improve from there.

If that proves worthwhile we could add it to the list of items in #617.

from recipe-scrapers.

jayaddison avatar jayaddison commented on July 29, 2024

(or any other Python linter you prefer)

from recipe-scrapers.

jayaddison avatar jayaddison commented on July 29, 2024

There's no hurry, thank you; hope you feel better soon.

from recipe-scrapers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.