Test fail with missing README.rst about recipe-scrapers HOT 3 CLOSED

Work fine. Thanks for your work.

from recipe-scrapers.

Thanks for the bugreport @marillat - I can confirm this after attempting a build from the python-recipe-scrapers 14.57.0-1 source.

The failing TestReadme.test_includes test as-described reads from a fixed README.rst path -- but after the Python package is built, the content of that file is only found within the package's recipe_scrapers-{vesion}.dist-info/METADATA file -- as the package's readme content (ref: the relevant pyproject.toml config).

Replacing the README.rst file open with some logic to open the *.dist-info/METADATA file works; the test runs and passes again; however I don't think it'd be great practice to have a unit test in the codebase here that has logic that is only exercised when downstream distros perform builds.

So a larger re-work may be required here; perhaps the test code needs to discover whether package metadata is available, and if so to check the contents of that -- otherwise fallback to README.rst. If we can do that, we should be able to add that as a check to one of our continuous integration workflows (perhaps the publish -- release -- workflow).

from recipe-scrapers.

@marillat version v14.57.1 has been released, and includes a change to the unit test suite so that it checks the scraper list using the Python package Description metadata -- which should be available during post-build package testing, as in your scenario -- instead of expecting the README.rst file to be available/copied into the test path.

That should allow re-enabling your tests downstream; please let me know whether that helps either way.

from recipe-scrapers.