hhsnopek / code-frame Goto Github PK

Version 10 of Node.js (code name Dubnium) has been released! 🎊

To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:

• Added the new Node.js version to your .travis.yml
• The new Node.js version is in-range for the engines in 1 of your package.json files, so that was left alone

If you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.

Your Greenkeeper Bot 🌴

code-frame inserts space before line number: " > 3", but babel-code-frame doesn’t.

I think we should take Babel’s style:

1. Consistency is always good.
2. Less symbols is better :D.

framer('\nfunction (foo) {\n\tconsole.log(foo\n}', 3, 24)
//   2 | function (foo) {
// > 3 |         console.log(foo
//     |                        ^
//   4 |

Why line 4 is empty? Do I understand correctly, that it is a issue and it should be with } — 4 | }?

I use node: 4.5.0 LTS

➜ node
> require('code-frame')
node_modules/code-frame/lib/index.js:3
module.exports = (input, line, col = -1) => {
                                   ^
SyntaxError: Unexpected token =
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:373:25)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at repl:1:1
    at REPLServer.defaultEval (repl.js:252:27)
    at bound (domain.js:287:14)
>

Fix is to check if the line number's length is the same, unless they're equal add space before border |

# current output
 9. |
 10. |

# fixed output
 9.  |
 10. |

Right now you have a got after line number (2.):

  2. | function (foo) {
> 3. |         console.log(foo
     |                        ^
  4. |

But, babel-code-frame, doesn’t have it (just 2):

  2 | function (foo) {
> 3 |         console.log(foo
    |                        ^
  4 |

@hhsnopek I want to use your awesome library in PostCSS, but I really need same output as in Babel (consistency UI is awesome)

Babel shows 2 lines before issue and 2 after. But code-frame only 1 line before and 1 after.

Should we make frame bigger? I think 3 lines is too short. Also again, UI consistency is awesome :D.

solves my \t problem

I see in the readme this is a smaller babel-code-frame, so was wondering what in particular made it slow/dependencies so we can improve it.

Would appreciate ideas/PRs if there's something that doesn't need to be there?